Closed
Bug 861093
Opened 12 years ago
Closed 12 years ago
"Ok" should be spelled "OK" in Facebook Contacts
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Firefox OS Graveyard
Gaia::Contacts
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: flod, Unassigned)
Details
Attachments
(1 file)
http://hg.mozilla.org/gaia-l10n/en-US/file/9eace57e1b78/apps/communications/contacts/fb/facebook.properties#l68
yesOption = Ok
This should be "OK" for consistency with other products and within Gaia itself (e.g. contacts.properties -> ok = OK)
No need to change the ID since you're just fixing a typo in English.
Hello Jose,
I have created a pull request(https://github.com/mozilla-b2g/gaia/pull/9980) for this bug. Please review it :)
Regards,
Attachment #753705 -
Flags: review?(jmcf)
|
||
Comment 3•12 years ago
|
||
the patch is ok. the only doub I have is if we should change the key name of the 'OK' option or not according to the L10N change policies. need info from :Pike
Flags: needinfo?(l10n)
|
||
Comment 4•12 years ago
|
||
flod's right. we should probably do a post to .l10n, though, the current results are 50-50 between localized, OK and Ok.
Flags: needinfo?(l10n)
|
|
||
Updated•12 years ago
|
Attachment #753705 -
Flags: review?(jmcf) → review+
|
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
Assignee | |
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•