861096 - Search/filter in reviewer tools fails because of Internal Server Error

Status: RESOLVED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P1)

Description

[Andreas Wagner [:TheOne] [use NI]]

https://marketplace.firefox.com/api/v1/apps/search/?q=&status=pending&app_type=&device=desktop&limit=200

returns HTTP 500, message:

{"error_code": "AttributeError", "error_data": {}, "error_message": "'NoneType' object has no attribute 'get_price_locale'"}

causing the search/filter feature in the reviewer tools to fail.

Comment 1

[Hanno Schlichting]

Relevant sentry is http://sentry.dmz.phx1.mozilla.com/addons/marketplace/group/13057 - but that has only a truncated message:

/api/v1/apps/search/: AttributeError 'NoneType' object has no attribute 'get_price_locale'
  File "/data/www/addons.mozilla.org/venv/lib/python2.6/site-packages/tastypie/resources.py", line 192, in wrapper
    response = callback(request, *args, **kwargs)

  File "/data/www/addons.mozilla.org/venv/lib/python2.6/site-packages/tastypie/resources.py", line 397, in dispatch_list
    return self.dispat

Comment 2

[Andrew Williamson [:eviljeff]]

its working now... *shurgs*

Comment 3

[Andrew Williamson [:eviljeff]]

re-opening this one as its happened again

Comment 6

[Andy McKay]

https://github.com/mozilla/zamboni/commit/f54bbf

Not sure if that's the issue, but its a bit saner.

Comment 7

[Victor Ng [:vng] [:crankycoder]]

https://github.com/mozilla/zamboni/commit/d09816f5

raven has 2 different SentryHandler classes.  I was using the wrong one by accident.  Request and User sections should show up now for tastypie generated errors.

Comment 8

[Andrew Williamson [:eviljeff]]

(In reply to Victor Ng [:vng] [:crankycoder] from comment #7)
> https://github.com/mozilla/zamboni/commit/d09816f5
> 
> raven has 2 different SentryHandler classes.  I was using the wrong one by
> accident.  Request and User sections should show up now for tastypie
> generated errors.

This should give us better errors but doesn't seem to address the actual bug.  
Andy - is this bug fixed?

Comment 9

[Victor Ng [:vng] [:crankycoder]]

:andym I don't have ES setup locally to check the test that broke https://ci.mozilla.org/job/marketplace/3713/ 

:eviljeff - the sentry fix just gives us better errors.  Sorry - I misunderstood the chatter on IRC.

Comment 10

[Andy McKay]

There wasn't enough info in the existing traceback to be sure. I did some code cleaning in the commit referenced in comment 6 and that should help. Let's close it for now and if it happens again, we'll re-open.

Comment 11

[Andy McKay]

https://github.com/mozilla/zamboni/commit/9e7aec

Well its a workaround, pending bug 864569.