861097 - [Buri][Beetle lite FF]The phone display date on status after power off animate

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P2)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.19.070
 Firefox os  v1.0.1
 Mozilla build ID:20130407070205
 +++ This bug was initially created as a clone of Bug #438304 +++
 
 Created an attachment (id=387137)
 capture screen
 
 DEFECT DESCRIPTION:
 The phone display date on status after power off animate
  REPRODUCING PROCEDURES:
 1.Power on the phone，tap the status bar，the status bar will be display date
 2.Long press power key then power off the phone，after the power off animate，the phone display date on status bar--K.O
 
  EXPECTED BEHAVIOUR:
 The phone should be not display status bar after power off animate
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 5/5
  For FT PR, Please list reference mobile's behavior:
 
 ++++++++++ end of initial bug #438304 description ++++++++++
 
 
 
 CONTACT INFO (Name,Phone number):
 
  DEFECT DESCRIPTION:
 
  REPRODUCING PROCEDURES:
 
  EXPECTED BEHAVIOUR:
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[xiupinglong]

Attachment: capture screen

Comment 2

[xiupinglong]

When tapping on status bar but the utility-tray contains notification is not showing onTouchEnd. The date will show on the status bar, and then it will overlap the notification count on status bar. It is also not correct either.

Comment 3

[xiupinglong]

Attachment: patch

After "ScreenManager.turnScreenOff(true)" it will fire screenchange event, So the icon for notification or date in status bar is showed after 3-rings animation.

I remove the reboot or poweroff code out the setTimeout in order to reboot or poweroff immediately.

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 744536 [details] [diff] [review]
patch

You need to reference a reviewer when setting the "review?" flag by putting his/her email or bugzilla nick in the field.

For this PR, I think Alive would be the best one.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 744536 [details] [diff] [review]
patch

r=me, the setTimer is redundant I think.

Comment 6

[xiupinglong]

Attachment: pull request

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 745731 [details] [diff] [review]
pull request

Why r? again?

Comment 8

[buri.blff]

(In reply to Alive Kuo [:alive] from comment #7)
> Comment on attachment 745731 [details] [diff] [review]
> pull request
> 
> Why r? again?

Sorry, I modified the commit info r=you. So I send a another pull request.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

You could 'git rebase' and choose rewording a specific commit and then force push to the same branch on your side.

Comment 10

[xiupinglong]

(In reply to Alive Kuo [:alive] from comment #9)
> You could 'git rebase' and choose rewording a specific commit and then force
> push to the same branch on your side.

Thank you! I will follow your advising next time.

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

master

https://github.com/mozilla-b2g/gaia/commit/74e702aa11ab85d15ddf9ca783de76e8dc498b14

Comment 12

[xiupinglong]

I commit a bug 870206 for comment 2.

Comment 13

[Daniel Coloma:dcoloma]

What is the user impact in this case? If the screen switched off after showing the date?

Comment 14

[xiupinglong]

As far as I know, 
1. if the date is not on the status bar before power off or restart, there may show
"icons.notification" icon (notification.count >=1) after press power off or restart.

2. if the date on status bar (not power off or restart), it will cover the notification, user can not see the notification icon and count.

3. after the power off animate，if the phone display date(or icons.notification) on status bar suddenly, user may feel confuse.

Comment 15

[Daniel Coloma:dcoloma]

Still don't understand. Is the device finally switched off or not?

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Daniel Coloma:dcoloma from comment #15)
> Still don't understand. Is the device finally switched off or not?

For this question the answer is yes.
This bug is talking about before the device power off, there would be a while that only statusbar's notification area displays but all other areas are black. Correct me if I am wrong.

Comment 17

[Daniel Coloma:dcoloma]

Then I do not think we should block on this bug.

Comment 18

[Alex Keybl [:akeybl]]

We'll take this given the very low risk profile and partner request. Adding verifyme to be 100% sure this doesn't cause shutdown regressions in v1.0.1. Thanks QA!

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 74e702aa11ab85d15ddf9ca783de76e8dc498b14 to:
v1-train: df9dce2861d34716b43a50a864db848faf98875a
v1.0.1: 15d13908a3f656dbd2d7ae436401e47fce6a291a

Comment 20

[mdaniloff]

This issue no longer reproduces on both Unagi V1.1 and Inari V1.0.1. When the user powers off their device, and after the power off animation occurs, no display date on the status bar is seen.

Unagi V1.1 build:20130603070207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/4785b1353fd7
Gaia: 4de4354e3a99f151a834743c7b03a041ac8db12f
Version 18.0


Inari V1.0.1 build: 20130603070208
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/42555e1e72fa
Gaia: fcae23654296c9cc645c2b7e77a2c36bf494803a
Version 18.0