86112 - View>Apply Theme selections bring up switching dialog when they shouldn't

Status: RESOLVED INVALID

(Core Graveyard :: Skinability, defect, P2)

Description

[Todd Pringle]

Build:  20010613

Steps to reproduce:

1)  From Nav, select View>Apply Theme>Get New Theme
 
or 

1)  From Nav, select View>Apply Theme>Theme Preferences
2)  Close themes pref panel without changing anything

Result:  You get the theme switching dialog.

Expected Result:  For 1) Go to theme park only, no dialog.
                  For 2) Close pref panel, no dialog.

Comment 1

[Todd Pringle]

Nominating.

Comment 2

[Paul Chen]

nav triage team:

Gotta fix this. Marking nsbeta1+, p2, and mozilla0.9.3

Comment 3

[Blake Ross]

I can't reproduce, are you still able to in a new build?

Comment 4

[Todd Pringle]

Blake, I still see this in the beta, but not the trunk (using 2001061804).

Comment 5

[Viswanath Ramachandran]

That is because the theme switching dialog is not there in the trunk at all :-). 

Comment 6

[Paul Chen]

nav triage team:

Since Ben is working on the defer skin switch until restart of app bug, pushing
this bug out to mozilla1.0

Comment 7

[Paul Chen]

Since I don't think we'll get dynamic skin switching in before mozilla1.0,
marking mozilla1.2

Comment 8

[Jeremy M. Dolan]

Expected Result: no dialog.

Er...dialog? Don't know what dialog you're talking about, but I don't get one.
INVALID/WFM.

Comment 9

[Julien Cegarra]

Because theme switching is now in that bug could be closed (Build ID: 2002 01 
16 04).

/jc

Comment 10

[Olav Vitters]

theme changes now happen dynamically