ARM asm.js hard-float ABI computation errors.

RESOLVED FIXED in mozilla23

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dougc, Unassigned)

Tracking

Trunk
mozilla23
ARM
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
When building for an ARM system ABI that uses the hard-float standard, passing the floating point operands in registers, the asm.js code is mis-compiled and errors shows up in the asm.js jit-tests.
(Reporter)

Comment 1

6 years ago
Created attachment 736766 [details] [diff] [review]
Fix the return of a floating point value from an ARM asm.js entry.

Just need to skip loading d0 from r0 and r1 when passing the result in d0.
Attachment #736766 - Flags: review?(mrosenberg)
Comment on attachment 736766 [details] [diff] [review]
Fix the return of a floating point value from an ARM asm.js entry.

Review of attachment 736766 [details] [diff] [review]:
-----------------------------------------------------------------

I would be very surprised if this were the only bug in the hardfp implementation, but that isn't a good reason to not land this.
Attachment #736766 - Flags: review?(mrosenberg) → review+
(Reporter)

Updated

6 years ago
Keywords: checkin-needed

Updated

6 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
https://hg.mozilla.org/mozilla-central/rev/fe1999ee55af
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.