Closed
Bug 861139
Opened 12 years ago
Closed 12 years ago
ARM asm.js hard-float ABI computation errors.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: dougc, Unassigned)
Details
Attachments
(1 file)
|
1013 bytes,
patch
|
mjrosenb
:
review+
|
Details | Diff | Splinter Review |
When building for an ARM system ABI that uses the hard-float standard, passing the floating point operands in registers, the asm.js code is mis-compiled and errors shows up in the asm.js jit-tests.
|
Reporter | |
Comment 1•12 years ago
|
||
Just need to skip loading d0 from r0 and r1 when passing the result in d0.
Attachment #736766 -
Flags: review?(mrosenberg)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 736766 [details] [diff] [review]
Fix the return of a floating point value from an ARM asm.js entry.
Review of attachment 736766 [details] [diff] [review]:
-----------------------------------------------------------------
I would be very surprised if this were the only bug in the hardfp implementation, but that isn't a good reason to not land this.
Attachment #736766 -
Flags: review?(mrosenberg) → review+
|
|
Reporter | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Updated•12 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
||
Comment 3•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•