861142 - Occasionally screenshots are missing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

Likely cause of bug 844726, sometimes screenshots can be missing if quickly exiting an app after launch.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Comment 2

[Kevin Grandon :kgrandon]

Landed in master: https://github.com/mozilla-b2g/gaia/commit/6f470aecc986153b73f22c4d7e961dcafa7e4bc4

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train and v1.0.1.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train and v1.0.1, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 6f470aecc986153b73f22c4d7e961dcafa7e4bc4
  <RESOLVE MERGE CONFLICTS>
  git commit
  git checkout v1.0.1
  git cherry-pick -x $(git log -n1 v1-train)

Comment 4

[James Lal [:lightsofapollo]]

Can you supply a patch to uplift / uplift yourself on effected branches?

Comment 5

[Kevin Grandon :kgrandon]

Landed in v1-train: https://github.com/mozilla-b2g/gaia/commit/0d0803b2d94858326855e58722241594022b799a

Cards view has greatly diverged from v1-train, and I would recommend a more general uplift of the entire feature if possible.

Comment 6

[James Lal [:lightsofapollo]]

Are we going to try to fix this in v1.0.1 ?

Comment 7

[Kevin Grandon :kgrandon]

It's a really tiny blemish that only occurs on edge conditions. I'd say no, as it's not really noticeable until we have the new task switcher implemented (it's much larger).

Comment 8

[Daniel Coloma:dcoloma]

We cannot update the whole feature, Kevin, any chance we could create a branch-specific patch for v1.0.1 or is the risk even higher? I assume the decision on this and on bug 844726 should be the same, right?

Comment 9

[Kevin Grandon :kgrandon]

I don't really want to uplift to v1.0.1 due to the risk at this time. Also it appears that very few people have been noticing/complaining of this issue so I don't think it warrants an uplift.