861152 - [Settings] Phone lock timeout select is not aligned with the other labels

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Screenshot unaligned timeout select

STR: Go to Settings > Phone lock > Enable "Passcode lock" > Set a passcode

After setting a passcode the user is returned to the "Phone lock" screen where a timeout select and a "Change Passcode" button are shown.

Actual: The timeout select is not aligned with the text labels and its width doesn't match the width of the button.

Expected: The timeout select from the Phone Lock screen (Settings app) should be aligned with the text labels and match the width of the "Change Passcode" button

NOTE: this doesn't reproduce on v1-train (54ab4ce), only on master (fa79f2f)

Comment 1

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #9143 - Fix padding for .fake-select

The patch for Bug 802234 changes the padding for .fake-select (Line 338 in apps/settings/style/lists.css) without actually needing it for the fix, from what I noticed. This breaks the alignment for the lock timeout select in "Phone lock" screen.

Comment 2

[Andrew Overholt [:overholt]]

I don't see this on v1.0.1 FWIW.

Comment 3

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

(In reply to Andrew Overholt [:overholt] from comment #2)
> I don't see this on v1.0.1 FWIW.

Hi Andrew, the behavior is observable only on master: commit 6fdf36c189e0963774abf44806fbfd948e16e531 from Bug 802234 introduces it. My patch fixes the error introduced by the respective commit -- if it is uplifted, then the commit containing this patch needs to be uplifted too (once it's merged to master).

Comment 4

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/55cbd19bf1e340cd2717fdaf9819fdd264039326