Closed
Bug 861184
Opened 11 years ago
Closed 11 years ago
Modularize binary search for valid column height in nsColumnSetFrame
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: jwir3, Assigned: jwir3)
References
Details
Attachments
(2 files, 1 obsolete file)
|
18.76 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
|
21.52 KB,
patch
|
Details | Diff | Splinter Review |
This is the third in a series of refactorings to nsColumnSetFrame in support of bug 846578. 3) Pull code from within nsColumnSetFrame::Reflow() that performs the binary search for a valid column height out into its own function.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → sjohnson
OS: Linux → All
Hardware: x86_64 → All
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #737502 -
Flags: review?(roc)
Attachment #737502 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
This hasn't landed yet because I'm trying to debug an issue with one of the pagination tests that seems to be failing with this patch applied...
|
|
Assignee | |
Comment 3•11 years ago
|
||
Fixed a couple of things that were causing reftest failures. The patch is essentially the same, but I thought since it's been a while since it was reviewed, and a few things changed, that I would re-request review as a sanity check. I'll post an interdiff shortly.
Attachment #737502 -
Attachment is obsolete: true
Attachment #772375 -
Flags: review?(roc)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Interdiff between the two versions of the patch.
Attachment #772375 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/70938baeafbd
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/70938baeafbd
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•