861249 - Contacts unit tests are failing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Anthony Ricaud (:rik)]

contacts_list_test.js is failing right now.

Alberto, ccing you since you are the module owner.

Comment 1

[alberto.pastor]

I fixed them on bug 848188, but I'll try to push a quick commit later.

Thanks!

Comment 2

[alberto.pastor]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9155

Pointer to Github pull-request

Comment 3

[Anthony Ricaud (:rik)]

Comment on attachment 736934 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9155

Great thanks. r+ with a small fix for one leak:
"global leak detected: asyncScriptsLoaded"

Comment 4

[alberto.pastor]

oh right, will be fixed in a minute

Comment 5

[alberto.pastor]

https://github.com/mozilla-b2g/gaia/commit/efec8783906d7dd3144ccdd4dd8381171050e900

Comment 6

[alberto.pastor]

Comment on attachment 736934 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9155

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):
String or UUID changes made by this patch:

Only tests fixes. Travis will be happy with this merge

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Andrew, I guess we can uplift this, is fixing the unit tests so travis won't stop in this error and will work properly.

Comment 8

[Andrew Overholt [:overholt]]

(In reply to Francisco Jordano [:arcturus] from comment #7)
> Andrew, I guess we can uplift this, is fixing the unit tests so travis won't
> stop in this error and will work properly.

For v1-train, right?  It sounds good to me and we'll make the call in the triage session starting in ~1 hour.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Andrew just asked for v1.0.1, do I need to add any other flag for v1-train?

Alberto commented he can do the uplift by himself.

Thanks!

Comment 10

[Andrew Overholt [:overholt]]

(In reply to Francisco Jordano [:arcturus] from comment #9)
> Andrew just asked for v1.0.1, do I need to add any other flag for v1-train?
> 
> Alberto commented he can do the uplift by himself.
> 
> Thanks!

All changes on v1.0.1 must come from blocking (tef+) bugs.  The approval here is just for v1-train.

Comment 11

[James Lal [:lightsofapollo]]

Patch does not cleanly apply to v1-train

Comment 12

[alberto.pastor]

v1-train: e5e3921871893c85feb342e38c58e7dae37bedb5