86132 - "Local Folders" (and movemail) should have "Disk Space" settings in account manager

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[(not reading, please use [e-mail] instead)]

"Local Folders" should have "Disk Space" settings in account manager

the place to start is in nsMsgAccountManagerDS.cpp, line 1089.

once you move the aNodeArray->AppendElement() out of the hasIdentities if 
block, the "Disk Space" panel will show up.

there will be no twisty, you'll have to fix 
nsMsgAccountManagerDataSource::HasArcOut() to get a twisty.

the real problem is am-offline.xul / am-offline.js does not play nice with 
servers of type "none" (or movemail).  we need to fix that. 

I think there is a bug about switching from using server types to using server 
attributes, like supportsDiskSpace and offlineSupportLevel.

fixing this bug should involve that cleanup, too.

Comment 1

[(not reading, please use [e-mail] instead)]

sorry, line 550.  search for bug #86132 in nsMsgAccountManagerDS.cpp

Comment 2

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 3

[Ian Neal]

Attachment: Adds twiddle and diskspace child to local folders

Changing from using server type to attribute is bug 63369

Comment 4

[Ian Neal]

Attachment: As above except using w too

Comment 5

[Ian Neal]

Attachment: Adds twiddle and diskspace child to local folders version 0.2

Checks offline supportlevel before checking supports disk space and also does
white space cleanup. This patch was made using -wpud8.

Comment 6

[Ian Neal]

Attachment: As above except without the w (i.e. pud8)

This is the one that would be checked in once r/sr granted.

Comment 7

[Ian Neal]

Attachment: Same as v0.2 but against latest trunk - this is the wpud8 version

Comment 8

[Ian Neal]

Attachment: The checkin (pud8) version of 0.2a

Comment 9

[David :Bienvenu]

+      rv = server->GetOfflineSupportLevel(&offlineSupportLevel);
+      NS_ENSURE_SUCCESS(rv,rv);
this never fails - it's a simple accessor

similarly, never fails
+      rv = server->GetSupportsDiskSpace(&supportsDiskSpace);
+      NS_ENSURE_SUCCESS(rv,rv);
We can save a little code and simply have:
        (void) server->Get...

other than that, looks fine...

Comment 10

[Ian Neal]

Attachment: Patch v0.2b - altered as per suggestions above (wpud8)

Comment 11

[Ian Neal]

Attachment: The checkin (pud8) version of patch v0.2b

Comment 12

[David :Bienvenu]

Comment on attachment 146524 [details] [diff] [review]
Patch v0.2b - altered as per suggestions above (wpud8)

thx, looks good.

Comment 13

[Ian Neal]

Checking in nsMsgAccountManagerDS.cpp;
/cvsroot/mozilla/mailnews/base/src/nsMsgAccountManagerDS.cpp
new revision: 1.99; previous revision: 1.98

Checking in am-offline.xul;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/am-offline.xul
new revision: 1.22; previous revision: 1.21

Fix checked into trunk by neil%parkwaycc.co.uk