Closed Bug 86132 Opened 23 years ago Closed 20 years ago
"Local Folders" (and movemail) should have "Disk Space" settings in account manager
"Local Folders" should have "Disk Space" settings in account manager the place to start is in nsMsgAccountManagerDS.cpp, line 1089. once you move the aNodeArray->AppendElement() out of the hasIdentities if block, the "Disk Space" panel will show up. there will be no twisty, you'll have to fix nsMsgAccountManagerDataSource::HasArcOut() to get a twisty. the real problem is am-offline.xul / am-offline.js does not play nice with servers of type "none" (or movemail). we need to fix that. I think there is a bug about switching from using server types to using server attributes, like supportsDiskSpace and offlineSupportLevel. fixing this bug should involve that cleanup, too.
sorry, line 550. search for bug #86132 in nsMsgAccountManagerDS.cpp
Summary: "Local Folders" should have "Disk Space" settings in account manager → "Local Folders" (and movemail) should have "Disk Space" settings in account manager
Assignee: racham → sspitzer
Status: ASSIGNED → NEW
Changing from using server type to attribute is bug 63369
Assignee: sspitzer → bugzilla
Status: NEW → ASSIGNED
Checks offline supportlevel before checking supports disk space and also does white space cleanup. This patch was made using -wpud8.
This is the one that would be checked in once r/sr granted.
+ rv = server->GetOfflineSupportLevel(&offlineSupportLevel); + NS_ENSURE_SUCCESS(rv,rv); this never fails - it's a simple accessor similarly, never fails + rv = server->GetSupportsDiskSpace(&supportsDiskSpace); + NS_ENSURE_SUCCESS(rv,rv); We can save a little code and simply have: (void) server->Get... other than that, looks fine...
Comment on attachment 146524 [details] [diff] [review] Patch v0.2b - altered as per suggestions above (wpud8) thx, looks good.
Attachment #146524 - Flags: review?(bienvenu) → review+
Attachment #146524 - Flags: superreview?(mscott) → superreview+
Checking in nsMsgAccountManagerDS.cpp; /cvsroot/mozilla/mailnews/base/src/nsMsgAccountManagerDS.cpp new revision: 1.99; previous revision: 1.98 Checking in am-offline.xul; /cvsroot/mozilla/mailnews/base/prefs/resources/content/am-offline.xul new revision: 1.22; previous revision: 1.21 Fix checked into trunk by neil%parkwaycc.co.uk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.0.1 → ---
You need to log in before you can comment on or make changes to this bug.