Closed Bug 861320 Opened 7 years ago Closed 6 years ago

HTMLMediaElement has no textTracks without a <source>

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: msaad, Assigned: reyre)

Details

Attachments

(2 files, 2 obsolete files)

HTMLMediaElement depends on having a <source> element in order to have a TextTrackList object. 

HTMLMediaElement should have a TextTrackList object regardless of a <source>
Attached file Test Case (obsolete) —
At line 18, HTMLMediaElement:HTMLVideoElement has no reference to TextTrackList.
At line 21, the reference is added after appending <source>
Attached file Test Case
Attachment #736942 - Attachment is obsolete: true
Jesus, this test looks awful. Will provide a new one.
Works for me on the current Nightly. Can you still reproduce Marcus?
Flags: needinfo?(mv.nsaad)
Assignee: nobody → rick.eyre
Rick, seems to be fixed with previous patches. Works for me
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Flags: needinfo?(mv.nsaad)
Resolution: --- → FIXED
Rick, can you get a test landed?
Flags: in-testsuite?
(In reply to :Ms2ger from comment #6)
> Rick, can you get a test landed?

Yep, I can do that.
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: FIXED → ---
Comment on attachment 8366053 [details] [diff] [review]
v1: HTMLMediaElement should have a list of TextTracks when the MediaElement has no source r=Ms2ger

Review of attachment 8366053 [details] [diff] [review]:
-----------------------------------------------------------------

I know nothing, sorry :)
Attachment #8366053 - Flags: review?(Ms2ger)
(In reply to :Ms2ger from comment #9)
> Comment on attachment 8366053 [details] [diff] [review]
> v1: HTMLMediaElement should have a list of TextTracks when the MediaElement
> has no source r=Ms2ger
> 
> Review of attachment 8366053 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I know nothing, sorry :)

Heh, no worries. I'll switch the review to Ralph :).
Attachment #8366053 - Flags: review?(giles)
Comment on attachment 8366053 [details] [diff] [review]
v1: HTMLMediaElement should have a list of TextTracks when the MediaElement has no source r=Ms2ger

Review of attachment 8366053 [details] [diff] [review]:
-----------------------------------------------------------------

Test looks good. It would have been simpler to just add the isnot to test_texttracklist.html rather than creating a new test file, but I'm ok with this if you prefer.
Attachment #8366053 - Flags: review?(giles) → review+
Thanks for review Ralph.

(In reply to Ralph Giles (:rillian) from comment #11)
> Comment on attachment 8366053 [details] [diff] [review]
> v1: HTMLMediaElement should have a list of TextTracks when the MediaElement
> has no source r=Ms2ger
> 
> Review of attachment 8366053 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Test looks good. It would have been simpler to just add the isnot to
> test_texttracklist.html rather than creating a new test file, but I'm ok
> with this if you prefer.

That does make more sense and would be a lot easier. I'll switch it over.
Moved the test to test_texttracklist.html and updated commit message to reflect that Ralph reviewed. Carrying forward r=rillian.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=426c3f1652db
Attachment #8366053 - Attachment is obsolete: true
Looks green.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/04469954cd44
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.