861333 - TEST-UNEXPECTED-FAIL | browser_dataman_basics.js | The correct number of domains is listed - Got 19, expected 18

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, defect)

Description

[Frank Wein [:mcsmurf]]

The browser_dataman_basics.js test fails because the number of default domains changed from 18 to 19. I thought I saw the checkin which changed this, but I can't find it anymore:
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/common/dataman/
tests/browser_dataman_basics.js | After search, the correct number of domains is
 listed - Got 19, expected 18
Stack trace:
[...]

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/common/dataman/
tests/browser_dataman_basics.js | The IPv6 domain has been removed from the list
 - Got 18, expected 17

and a few other test fails.

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Robert: Bug 722299 added a new host to build/pgo/server-locations.txt, which changes the number of hosts in data manager (as a host with xbl/xul privs was added). That bug also changed the IDN algorithm, some xn--... host is now displayed as exämple.test. That is why I needed to change some numbers in the test. But the new host that was added serves as replacement as that one is still displayed in punnycode notation.

Comment 2

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/comm-central/rev/758434b4079b

Comment 3

[Frank Wein [:mcsmurf]]

Comment on attachment 737009 [details] [diff] [review]
Patch

[Approval Request Comment]
Regression caused by (bug #): Bug 722299
User impact if declined: none, test-only fix
Testing completed (on m-c, etc.): Works on comm-central
Risk to taking this patch (and alternatives if risky): none, test-only fix
String changes made by this patch:

Comment 4

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/releases/comm-aurora/rev/91d956e8ff79