get rid of checks for FPU_IS_ARM_FPA

RESOLVED FIXED in mozilla23

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: froydnj, Unassigned)

Tracking

unspecified
mozilla23
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
We only ever check whether it's defined, and no headers or configury sets it.

Archaeology suggests that it used to be defined in jsnum.h, but an Executive Decision was made to only support VFP.  (A good decision!)
(Reporter)

Comment 1

6 years ago
Created attachment 736961 [details] [diff] [review]
delete checks for FPU_IS_ARM_FPA
Attachment #736961 - Flags: review?(mrosenberg)
Comment on attachment 736961 [details] [diff] [review]
delete checks for FPU_IS_ARM_FPA

Review of attachment 736961 [details] [diff] [review]:
-----------------------------------------------------------------

I seem to remember that I got this macro from the methodjit.  Have you checked if it is used there?
Attachment #736961 - Flags: review?(mrosenberg) → review+
(Reporter)

Comment 3

6 years ago
(In reply to Marty Rosenberg [:mjrosenb] from comment #2)
> I seem to remember that I got this macro from the methodjit.  Have you
> checked if it is used there?

grep says these three places were the only occurrences left in the tree.

https://hg.mozilla.org/integration/mozilla-inbound/rev/175149690cbb
https://hg.mozilla.org/mozilla-central/rev/175149690cbb
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.