Closed
Bug 861401
Opened 11 years ago
Closed 11 years ago
Make subview transitions work again
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(1 file)
|
743 bytes,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
I just realized that bug 860562 broke the transition where the subview comes in from the side. This is because I overzealously added a rule that sets display: none; on the subview when its not displaying. When the panel is set to view a subview, an attribute is set, and the display:none doesn`t apply, and the animation should occur. Unfortunately, it seems that display: none; somehow overrides the animation from occurring - I guess before it`s removed. So the animation never happens, and the element just snaps to its final destination. Demo: http://jsbin.com/ocunup/1/edit
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → mconley
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #736987 -
Flags: review?(jaws)
|
||
Updated•11 years ago
|
Attachment #736987 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
Fixed in Jamun as https://hg.mozilla.org/projects/jamun/rev/ece546b8abd2 Fixed in UX as https://hg.mozilla.org/projects/ux/rev/ece546b8abd2
Whiteboard: [fixed in jamun][fixed in ux]
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3b972acc15e9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in jamun][fixed in ux]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•