86144 - ldap url search filter assumes parentheses

Status: VERIFIED FIXED

(Directory :: LDAP XPCOM SDK, defect, P2)

Description

[mwyner (gone)]

1) Create a new ldap directory instance to use for addressing
2) Under the "advanced tab" in the prefs for that server, put in objectclass=*
for the search filter. Also fill out all the other prefs.
3) Quit and restart the browser, and then create a new message, put something in
the "to" field and watch the browser connect to the ldap server.
Notice it doesn't work. It will connect to the server, but it will not actually
do a search.

However, the default search filter if you don't put anything in that field is
(objectclass=*) which will work without a problem.

The code however should not assume there are parens there since the search
filter without the parens is valid.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: patch, v1

Comment 2

[Leif Hedstrom]

Looks good, r=leif.

-- Leif

Comment 3

[Darin Fisher]

from irc:

<darin> wouldn't it be more efficient to use operator+= instead of operator+ ?
<dmose> where?
<darin> prefix = NS_LITERAL_STRING("(&");
<darin> prefix += NS_ConvertUTF8toUCS2(urlFilter);
<darin> etc.
<dmose> hmmmm
<darin> scc would know better than i, but i thought that operator+ always
involved an extra copy

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Talked the string fu over with scc and darin in irc, and it turns out the patch
as it stands will be fastest, because there will be one single allocation rather
than multiple allocations.

From my irc window:

<darin> sr=darin

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Fix checked into the trunk.

Comment 6

[Jussi-Pekka Mantere]

Nominating for nsBranch.

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

This isn't gonna be accepted on the branch.  Since it is fixed on the trunk,
resolving.

Comment 8

[yulian chang]

Verified with 2001080603 Windows trunck build.