ldap url search filter assumes parentheses

VERIFIED FIXED in mozilla0.9.3

Status

P2
major
VERIFIED FIXED
18 years ago
16 years ago

People

(Reporter: mwyner, Assigned: dmose)

Tracking

other
mozilla0.9.3
PowerPC
Mac System 9.x

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
1) Create a new ldap directory instance to use for addressing
2) Under the "advanced tab" in the prefs for that server, put in objectclass=*
for the search filter. Also fill out all the other prefs.
3) Quit and restart the browser, and then create a new message, put something in
the "to" field and watch the browser connect to the ldap server.
Notice it doesn't work. It will connect to the server, but it will not actually
do a search.

However, the default search filter if you don't put anything in that field is
(objectclass=*) which will work without a problem.

The code however should not assume there are parens there since the search
filter without the parens is valid.
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9.3

Comment 2

18 years ago
Looks good, r=leif.

-- Leif

Comment 3

18 years ago
from irc:

<darin> wouldn't it be more efficient to use operator+= instead of operator+ ?
<dmose> where?
<darin> prefix = NS_LITERAL_STRING("(&");
<darin> prefix += NS_ConvertUTF8toUCS2(urlFilter);
<darin> etc.
<dmose> hmmmm
<darin> scc would know better than i, but i thought that operator+ always
involved an extra copy
(Assignee)

Comment 4

18 years ago
Talked the string fu over with scc and darin in irc, and it turns out the patch
as it stands will be fastest, because there will be one single allocation rather
than multiple allocations.

From my irc window:

<darin> sr=darin
(Assignee)

Comment 5

18 years ago
Fix checked into the trunk.
(Assignee)

Updated

18 years ago
Whiteboard: fix checked into trunk; would like approval for branch checkin

Comment 6

18 years ago
Nominating for nsBranch.
Keywords: nsBranch
(Assignee)

Comment 7

18 years ago
This isn't gonna be accepted on the branch.  Since it is fixed on the trunk,
resolving.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Keywords: nsBranch
Resolution: --- → FIXED
Whiteboard: fix checked into trunk; would like approval for branch checkin

Comment 8

17 years ago
Verified with 2001080603 Windows trunck build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.