861466 - [Buri][STK] Other characters except (0-9, *, #, and +) shouldn't be input in get input proactive command with bit1=0 in Command Qualifier

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[sync-1]

+++ This bug was initially created as a clone of Bug #438388 +++
 
 DEFECT DESCRIPTION:
 [REG][STK] Other characters except (0-9, *, #, and +) shouldn't be input in get input proactive command with bit1=0 in Command Qualifier
 
  REPRODUCING PROCEDURES:
    1. Load one simulated SIM card which can send "get input".
    2. Run case STM03002-> case2,"get input" with parameter bit1=0 in Command Qualifier.
    3. some character except (0-9, *, #, and +) all can input --->KO,when get input with bit1=0 in Command Qualifier ,ME should only allow input "0~9,*,#,+" .
 
 besides, In hidden entry mode, only digits from the set "0-9","*" and "#" are allowed for the user input. "+" is not allowed for user input in this mode.
 
  EXPECTED BEHAVIOUR:
 (0-9, *, #, and +) should only be input in get input proactive command with bit1=0 in Command Qualifier
 
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:
 
 ++++++++++ end of initial bug #438388 description ++++++++++
 
 
 
 CONTACT INFO (Name,Phone number):
 
  DEFECT DESCRIPTION:
 
  REPRODUCING PROCEDURES:
 
  EXPECTED BEHAVIOUR:
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[xiaohui]

Dear Mozilla,

Please update the status.

Thanks!

Comment 2

[Carol Yang [:cyang]]

> 3. some character except (0-9, *, #, and +) all can input --->KO,when get input with bit1=0 in Command Qualifier ,ME should only allow input "0~9,*,#,+" .

This issue has already been fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=847033. Please try running with latest AU.

>  besides, In hidden entry mode, only digits from the set "0-9","*" and "#" are allowed for the user input. "+" is not allowed for user input in this mode.

I do see a full keyboard show up for this case.

Is this a cert blocker?

Comment 3

[sync-1]

https://bugzilla.mozilla.org/show_bug.cgi?id=847033. just fix on one condition,CQ=00 is a example of bit1=0 in Command Qualifier;
 for example, when CQ=04 also mean bit1=0 in Command Qualifier, it should display the keypad which can input (0-9, *, #, and +) . but now still can input some other characters except (0-9, *, #, and +) .

Comment 4

[sync-1]

Dear Mozilla,
 We have fixed this bug, please close it.
 
 Code in icc.js
 'hideInput' will cover 'tel', so we should add judgement for tel after hideInput.
     if (options.hideInput) {
       input.type = 'password';
 	if (!options.isAlphabet) 
 	{
 		input.type = 'tel';
 	}
     }
 
 Thanks!

Comment 5

[sync-1]

The new ref is updated by  with patch_delivery script!
 
 ###%%%comment:Only enable input 0-9, *, # and + when input pwd isn't alphabet
 ###%%%bug number:438388 ###%%%product name:beetle-lite-v1.0-dint ###%%%root
 cause:Coding ###%%%Module_Impact:STK ###%%%Test_Suggestion:RUN STK
 ###%%%Solution:Only enable input 0
 
 Branch: refs/heads/beetle-lite-v1.0-dint
 http://gitweb.tcl-ta.com:8081/#change,89724
 http://gitweb.tcl-ta.com/gitweb.cgi?p=platform_b2g/mozilla-b2g/gaia.git;a=commit;h=8df13e663046258bc643d962ec12a3bdb5d4fb17

Comment 6

[sync-1]

Dear Mozilla,
 
 Correction:
 
 This case need to use 'password' keyboard, not 'tel', we just need to add input restrict, only "0-9 * # + " allowed to input.
 
 
 
 Icc.js
 
     if (options.hideInput) {
       input.type = 'password';
       // Modification begin
       if (!options.isAlphabet) 
       {
         inputPwdTel = true;
       }
       //Modification  end
     }
 
     input.onkeyup = function(event) {
       if (inputTimeOutID) {
         clearTimeout(inputTimeOutID);
         inputTimeOutID = null;
       }
       if (input.type === 'tel') {
         // Removing unauthorized characters
         console.log('TEL keypad. Remove unauthorized characters: ' +
           input.value);
         input.value = input.value.replace(/[()-]/g,'');
         console.log('TEL keypad. Final entry: ' + input.value);
       }
       // Modification begin
       debug('inputPwdTel: ' + inputPwdTel);
       if(inputPwdTel){
         input.value = input.value.replace(/[^0-9*#+]/g,'');
       }
       // Modification  end
       button.disabled = !checkInputLengthValid(input.value.length,
                                               options.minLength,
                                               options.maxLength);
     };

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

removing feature-b2g:2.2 nomination as I don't see it's in the must-have list.

Comment 8

[BMO Automation]

Firefox OS is not being worked on