puppet reinstalls mozillapulse package on every run

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
4 months ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [puppet])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
From https://bugzilla.mozilla.org/show_bug.cgi?id=803823#c20

In reply to Rail Aliiev [:rail] from comment #19)
> 
> 2) One of the Python modules is being installed on each puppet run:
> 
> notice:
> /Stage[main]/Buildmaster::Queue/Python::Virtualenv[/builds/buildbot/queue]/
> Python::Virtualenv::Package[/builds/buildbot/
> queue||mozillapulse==a2d95569a089e]/Exec[pip
> /builds/buildbot/queue||mozillapulse==ad95569a089e]/returns: executed
> successfully
> 
> Sounds like a bug in python::virtualenv::package, probably related to
> changeset-as-version.


http://puppetagain.pub.build.mozilla.org/data/python/packages/mozillapulse-ad95569a089e.tar.bz2 reports itself as "MozillaPulse .4" - version mismatch :/ 

We can fix ugly ".4" version and generate another tarball (may require adding a branch to http://hg.mozilla.org/automation/mozillapulse/ (even anon)) or grab the latest 0.61 version.
(Assignee)

Comment 1

5 years ago
Created attachment 737194 [details] [diff] [review]
puppet

I tested this locally:

$ mkdir /tmp/pulse
$ wget -O /tmp/pulse/mozillapulse-.4.tar.bz2 http://puppetagain.pub.build.mozilla.org/data/python/packages/mozillapulse-ad95569a089e.tar.bz2
$ mkvirtualenv pulse
$ pip install pytz carrot
$ python ./modules/python/files/pip-check.py mozillapulse==.4
not found - exit status 0
$ pip install --no-index --find-links file:///tmp/pulse mozillapulse==.4
$ python ./modules/python/files/pip-check.py mozillapulse==.4
found - exit status 1
Attachment #737194 - Flags: review?(catlee)
(Assignee)

Updated

5 years ago
Assignee: nobody → rail
Comment on attachment 737194 [details] [diff] [review]
puppet

Review of attachment 737194 [details] [diff] [review]:
-----------------------------------------------------------------

How will we install the initial version on a fresh master?
(Assignee)

Comment 3

5 years ago
(In reply to Chris AtLee [:catlee] from comment #2)
> How will we install the initial version on a fresh master?

I did
cp -avi mozillapulse-ad95569a089e.tar.bz2 mozillapulse-.4.tar.bz2
on puppetagain server.
http://puppetagain.pub.build.mozilla.org/data/python/packages/mozillapulse-.4.tar.bz2
(Assignee)

Comment 4

5 years ago
pip install --no-index --find-links http://puppetagain.pub.build.mozilla.org/data/python/packages mozillapulse==.4 

worked fine

Updated

5 years ago
Attachment #737194 - Flags: review?(catlee) → review+
(Assignee)

Comment 6

5 years ago
Yay!
# puppet agent --test
info: Retrieving plugin
info: Loading facts in /var/lib/puppet/lib/facter/num_masters.rb
info: Caching catalog for buildbot-master51.srv.releng.use1.mozilla.com
info: Applying configuration version '1366027558'
notice: Finished catalog run in 15.51 seconds
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.