Closed Bug 861652 Opened 8 years ago Closed 8 years ago

ics parser is missing listener, everything is called synchronously

Categories

(Calendar :: Internal Components, defect)

Product:
Calendar
Component:
Internal Components
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(1 file)

Fix - v1
785 bytes, patch
mmecca
: review+
Details | Diff | Splinter Review
Attached patch Fix - v1 — — Splinter Review 
The listener is not saved in the state object, which means the parer is always being handled synchronously.

Testcase in bug 861620.
Attachment #737275 - Flags: review?(matthew.mecca)
Flags: in-testsuite+
Comment on attachment 737275 [details] [diff] [review]
Fix - v1

The patch doesn't seem to affect the results of the testcase, but otherwise looks good. r=mmecca
Attachment #737275 - Flags: review?(matthew.mecca) → review+
Pushed to comm-central changeset 18f37bd4030e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.5
You need to log in before you can comment on or make changes to this bug.