86171 - Wrong return value in nsAccessProxy.h (DOMEventListener:HandleEvent)

Status: VERIFIED FIXED

(Core :: DOM: Events, defect)

Description

[Mike Kaply [:mkaply]]

This is a one liner that should be reviewed by DOM, so I thought it 
best to give it to DOM rather than trying to route it through 
accessibility.

In mozilla/extensions/access-builtin/accessproxy/nsAccessProxy.h

HandleEvent is defined to return an nsresult when it should return an 
NS_IMETHOD.

Index: nsAccessProxy.h
===================================================================
RCS file: 
/cvsroot/mozilla/extensions/access-builtin/accessproxy/nsAccessProxy.h
,v
retrieving revision 1.1
diff -u -1 -r1.1 nsAccessProxy.h
--- nsAccessProxy.h	2001/02/16 04:07:22	1.1
+++ nsAccessProxy.h	2001/06/15 23:46:13
@@ -69,3 +69,3 @@
   //NS_DECL_NSIACCESSPROXY
-  virtual nsresult HandleEvent(nsIDOMEvent *event);  // This compiles 
on Windows
+  virtual NS_IMETHOD HandleEvent(nsIDOMEvent *event);  // This 
compiles on Windows

Comment 1

[Mike Kaply [:mkaply]]

aaron,

You might want to just checkin this one line fix. The symantics are wrong.

Comment 2

[joki (gone)]

I'll get this in with my 0.9.3 stuff.  Aaron, want to give it an r for me?

Comment 3

[Aaron Leventhal]

r=aaronl

Comment 4

[Aaron Leventhal]

Was fixed as part of another checkin

Comment 5

[Vladimir Ermakov]

verifying per aaron's coments.