861721 - After setting up a peer connection handshake with data channels, if I send a message while offline, then come back online, I will never be able to send messages ever again

Status: NEW

(Core :: WebRTC: Networking, defect, P5)

Description

[Jason Smith [:jsmith]]

STR:

1. Load the attached test case while online
2. Setup the handshake online
3. Kill the network
4. Send a message with one character for the local DC
5. Come back online
6. Try sending a message again with one character

Expected:

Debatable. If the connection between two data channels is lost, I'd potentialy expect onclose to fire to indicate that the channels have been closed due to loss of network connectivity temporarily. If it's possible technically to still continue, then I'd expect the message to be sent when you come back online.

Actual:

All sent messages are lost when you come back online. No onclose event fires either. So if a user loses network connectivity after a handshake is established between a local and remote peer with data channels, the connection is permanently lost when we lose connectivity. 

So why aren't we telling the developer the connection was lost permanently? Why can't we send messages again when we come back online?

Comment 1

[Jason Smith [:jsmith]]

Attachment: Test Case

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

How are you going offline?  Removing the cable, or using the OS to disable the network connection?  Or by selecting the browser menu item "Work offline"?  If the latter, I believe that calls close() on all PeerConnections (connected or not!)  Whether it should (and what errors should be thrown) is a question for discussion.

Comment 3

[Jason Smith [:jsmith]]

(In reply to Randell Jesup [:jesup] from comment #2)
> How are you going offline?  Removing the cable, or using the OS to disable
> the network connection?  Or by selecting the browser menu item "Work
> offline"?  If the latter, I believe that calls close() on all
> PeerConnections (connected or not!)  Whether it should (and what errors
> should be thrown) is a question for discussion.

I chose work offline to move to go offline during this test case.

Comment 4

[Lennart Grahl [:lgrahl]]

It definitely doesn't call pc.close() at the moment but it probably should (and then just follow the spec from that on).

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Likely fixed