861730 - Bluetooth page in Settings becomes very strange if the patch of bug 828890 is applied

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Eric Chou [:ericchou] [:echou]]

I just pulled the latest Gaia/vi-train and found that Bluetooth page becomes very strange when the patch of bug 858722 is applied. The toggle button won't be enabled after it's tapped. No idea what the root cause is, an expert is needed.

Comment 1

[Eric Chou [:ericchou] [:echou]]

= Version info =

Gaia/vi-train
commit 82e27cabdc205f41438e8a356fa61b2460d878d3
Author: Fabien Cazenave <[e-mail]>
Date:   Thu Apr 11 01:43:33 2013 -0700

    Merge pull request #9065 from etiennesegonzac/bug-858722-settings-permission
    
    Bug 858722 - Fixing the busted permissions panel of the settings app, r=kaze

Gecko/b2g18
changeset:   119059:c0cd11d99953
tag:         tip
user:        Brian Smith <[e-mail]>
date:        Thu Apr 11 17:43:06 2013 -0700
summary:     Bug 839141: Update NSS to NSS 3.14.3 (NSS_3_14_3_RTM), a=akeybl, r=me

Comment 2

[Eric Chou [:ericchou] [:echou]]

(In reply to Eric Chou [:ericchou] [:echou] from comment #0)
> I just pulled the latest Gaia/vi-train and found that Bluetooth page becomes
> very strange when the patch of bug 858722 is applied. The toggle button
> won't be enabled after it's tapped. No idea what the root cause is, an
> expert is needed.

I need to revise my comment: bug 828890 is the commit caused the problem, not bug 858722.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/9167

One item was missed during the uplifting. Evelyn, could you help review the change? Thanks!

Comment 4

[Evelyn Hung]

Comment on attachment 737375 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/9167

r=me, thanks for helping on this.

Comment 5

[Evelyn Hung]

it's a regression of bug 828890, since it's not a leo+ but landed with Dietrich's approve. We may need to ask approval instead of nominate leo?.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 737375 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/9167

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 828890 
User impact if declined: Users are not able to use bluetooth.
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): None
String or UUID changes made by this patch: None

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 737375 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/9167

leo+, so no approval necessary

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

v1-train: https://github.com/mozilla-b2g/gaia/commit/de7ce6855bb61950a6e014a50c4aa6dad3181be2

Comment 9

[Walter Chen[:ypwalter][:wachen]]

Verified fixed on 2013-04-17 pvt pub build