Closed Bug 861783 Opened 7 years ago Closed 7 years ago

Removing watch expression of large object not possible via mouse

Categories

(DevTools :: Debugger, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 23

People

(Reporter: jryans, Assigned: vporof)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file)

If the watch expression results in a large object that, when expanded, triggers a vertical scrollbar in the variables view that was not present before, then it is not possible to remove the watch expression by clicking the X icon.  Instead the watch expression toggles between expanded and collapsed with each attempt to click the X.

This is similar to bug 846208, but slightly more serious since it's not possible to remove the watch at all.

STR:

1. Go to http://mihaisucan.github.io/mozilla-work/test.html
2. Add a breakpoint to line 4 of test.js
3. Add a watch expression for "this"
4. Refresh the page to trigger the breakpoint
5. Attempt to remove the watch expression
Attached patch v1Splinter Review
Also removed a typo in VV__disableSearch.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #737682 - Flags: review?(past)
Comment on attachment 737682 [details] [diff] [review]
v1

Review of attachment 737682 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/shared/widgets/VariablesView.jsm
@@ +404,5 @@
>        return;
>      }
>      this._searchboxContainer.parentNode.removeChild(this._searchboxContainer);
> +    this._searchboxNode.removeEventListener("input", this._onSearchboxInput, false);
> +    this._searchboxNode.removeEventListener("keypress", this._onSearchboxKeyPress, false);

lol
Attachment #737682 - Flags: review?(past) → review+
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/6f992295d9ac
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.