Display "Unknown" if the phone number is not available on the SIM card (from Vodafone ES, Movistar, etc.)

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: hub, Assigned: hub)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

45 bytes, text/x-github-pull-request
kaze
: review+
Details | Review | Splinter Review
(Assignee)

Description

5 years ago
Setting > Device Info

There is no phone number displayed.

This is with the Vodafone ES sim card that I got here.
I see this as well with the latest 1.0.1 build using Happy Movil SIM card.
(Assignee)

Comment 2

5 years ago
Nor do I get it with the m2m Solutions (telefonica) Movistar.
Phone number is stored in ICC EF_MSISDN file. According to the specs http://www.etsi.org/deliver/etsi_ts/151000_151099/151011/04.14.00_60/ts_151011v041400p.pdf it is "Optional".
MSISDN should be here if service #21 is available. This is not checked in getSST() method of ril_worker.js.
(Assignee)

Comment 6

5 years ago
I tested the SIM card in my Samdroid phone and it says "Unknown" for the phone number. Maybe we should display this instead of a blank field.
(Assignee)

Updated

5 years ago
Summary: Phone number not available (Device info) (Vodafone ES) → Display "Unknown" if the phone number is not available on the SIM card (from Vodafone ES, Movistar, etc.)
(Assignee)

Comment 7

5 years ago
Created attachment 737942 [details] [review]
Pull request

Proposed patch. Against v1-train.
Attachment #737942 - Flags: review?(etienne)
(Assignee)

Updated

5 years ago
Assignee: nobody → hub
Comment on attachment 737942 [details] [review]
Pull request

I'm not a Settings app peer, so better to ask :kaze for review, but quick comments:

- we don't send PRs against v1-train directly, we land on master then uplift (if we get the approvals)
- the patch contains new l10n-keys, if we want the patch to be upliftable we need a l10n review
Attachment #737942 - Flags: review?(etienne) → review-
(Assignee)

Comment 9

5 years ago
I wasn't sure who was peer :-/ I'll ask :kaze.

How do I ask for a l10n review?

(I did against v1-train because that's what I run)
(Assignee)

Comment 10

5 years ago
Created attachment 738094 [details] [review]
Pull request

Against master
Attachment #737942 - Attachment is obsolete: true
Attachment #738094 - Flags: review?(kaze)
(Assignee)

Comment 11

5 years ago
Created attachment 753313 [details] [review]
Pull request

Rebased PR.
Attachment #738094 - Attachment is obsolete: true
Attachment #738094 - Flags: review?(kaze)
Attachment #753313 - Flags: review?(kaze)
Thanks for the patch. I have a few remarks, see my comments on github.
(Assignee)

Comment 13

5 years ago
I have updated the PR request.
Comment on attachment 753313 [details] [review]
Pull request

LGTM
Attachment #753313 - Flags: review?(kaze) → review+

Comment 15

5 years ago
Also Latvian and Israeli SIM cards does not display phone number, perhaps no phone number detected from any SIM.
(Assignee)

Comment 17

5 years ago
(In reply to Binyamin from comment #15)
> Also Latvian and Israeli SIM cards does not display phone number, perhaps no
> phone number detected from any SIM.

This is optional. Some carrier have it, some don't. That's the gist of this bug. T-Mobile Germany for example has it.
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain text/plain → text/x-github-pull-request text/x-github-pull-request
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.