Closed Bug 861836 Opened 8 years ago Closed 8 years ago

Duplicate HTML ID in Cost Control app

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Other
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zcampbell, Assigned: mai)

Details

Attachments

(1 file)

This is not evident in practice but is visible by performing:

1. Loading Cost Control app (complete/dismiss the FTE screens)
2. Open Settings
3. View the HTML source.

On Gaia commit: 
bc1fd377bf / v1-train.


  <body role="application">
    <section id="settings-view" class="window skin-organic" role="region">
      <!-- Settings view -->
      <section class="view" id="settings-view" role="region">
        <header data-theme="organic">
          <menu type="toolbar">
             <button data-l10n-id="done" id="close-settings">Done</button>
          </menu>
          <h1 data-l10n-id="settings">Settings</h1>
        </header>
.............
Can you double check this now?
Flags: needinfo?(zcampbell)
Yes it is still valid.
Flags: needinfo?(zcampbell)
Please, :mai, take a look when you have some free band with. We don't want duplicated ids and tricky bugs x)
Assignee: nobody → mri
blocking-b2g: --- → 1.4?
Attached file patch v1.0
Please, could you review the patch
Attachment #8357770 - Flags: review?(salva)
Comment on attachment 8357770 [details]
patch v1.0

Working perfectly. Thank you :mai.
Attachment #8357770 - Flags: review?(salva) → review+
Master: 002cca258af8586859c6efb2dada2fcec36754a1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Already landed, will be part of 1.4.
blocking-b2g: 1.4? → ---
You need to log in before you can comment on or make changes to this bug.