[regression] You cannot redail from BT earphone in case dialer is not opened

RESOLVED FIXED

Status

Firefox OS
Gaia::Dialer
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: alive, Assigned: etienne)

Tracking

({regression})

unspecified
ARM
Gonk (Firefox OS)
regression

Firefox Tracking Flags

(blocking-b2g:-, b2g18+)

Details

Attachments

(1 attachment)

STR:
1. Pair a BT earphone.
2. Dail a number from dialer.
3. Kill Dialer from cardview.
4. Press redail(double press dial button from BT earphone in most cases)

Expected:
1. You could redail to the last number you dialed

Actual:
Nothing happens

Note:
This seems like the regression caused from lazy loading work in dailer.
I've a small patch to fix this.
Summary: You cannot redail from BT earphone in case dialer is not opened → [regression] You cannot redail from BT earphone in case dialer is not opened

Comment 1

5 years ago
Please nominate a low risk fix for v1.1 if/when available. This isn't a blocker for v1.0.1, however, since the user will still be able to easily redial from the dialer (and we're hoping that LMK stops killing the dialer soon).
blocking-b2g: tef? → -
tracking-b2g18: --- → +
Keywords: regression
(In reply to Alex Keybl [:akeybl] from comment #1)
> Please nominate a low risk fix for v1.1 if/when available. This isn't a
> blocker for v1.0.1, however, since the user will still be able to easily
> redial from the dialer (and we're hoping that LMK stops killing the dialer
> soon).

The problem also occurs when the phone reboots and before the user manually opens the dialer.
The fix would be a small one (just skip unnecessary module checking).
Hi Etienne,
As we talked this morning, it is possible BT command ATD failed. Please help to make sure this patch phased in.
blocking-b2g: - → tef?
This impacted BT headset cannot dial outgoing call or doing redial, which is critical.
WIP

https://github.com/alivedise/gaia/commit/40ca13a2ad32accf77860d8d6e5a28bc72aef572

I think the way with last impact is to check MmiManager/USSDManager existence when BT tries to redial via system message to open dialer. However this may not works when the last number is an USSD number.
Furthermore, the USSDManager/MmiManager is not loaded anymore when dial from system message handler.
Hi, Alex
Would you please re-consider to nominate it as tef+? This is really bad for bluetooth usage and bluetooth certification.

Comment 8

5 years ago
We'll track this and take an uplift request on v1.1, but this won't block a release. This doesn't block bluetooth certification according to partners.
blocking-b2g: tef? → -
Hi Etienne,
As we talked, BT command ATD/BLDN cannot work before the user manually opens the dialer. I believe many test cases cannot be proceed and also impact user normal usage.
Assignee: alive → etienne
blocking-b2g: - → leo?
As per comment 8, unless someone points to a certification issue with this bug in particular, it is not a blocker but a low risk fix might still be able to uplift - nominated patch for consideration when available.
blocking-b2g: leo? → -
Hi Etienne,
As Comment 5 mentioned, I think the patch is low risk fix, and we can get rid of failure, can we get fix in v.1.1?
Flags: needinfo?(etienne)
(Assignee)

Comment 12

5 years ago
Created attachment 741283 [details] [diff] [review]
Patch proposal

Here's a patch proposal.
Alive, can you have a look? It's a bit cleaner do to it that way IMHO.

Shawn, is it fixing the issue?
Attachment #741283 - Flags: review?(alive)
Attachment #741283 - Flags: feedback?(shuang)
Flags: needinfo?(etienne)
Comment on attachment 741283 [details] [diff] [review]
Patch proposal

The logic looks good to me!
Attachment #741283 - Flags: review?(alive) → review+
Comment on attachment 741283 [details] [diff] [review]
Patch proposal

Etienne, I've tested over 10 times, it looks great for me. I really hope fix can be submitted to v.1.1 and v.1.0.1, otherwise we might get complain about Bluetooth can not dial out if this patch has been evaluated as low risk. Thanks again.
Attachment #741283 - Flags: feedback?(shuang) → feedback+
(Assignee)

Comment 15

5 years ago
https://github.com/mozilla-b2g/gaia/commit/63b5558fef71fb74a3f94e3827efcbed3804f367
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.