B2G Desktop does not compile on Ubuntu 12.04 due to bluetooth socket type issues

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: qdot, Assigned: qdot)

Tracking

unspecified
x86_64
Linux

Firefox Tracking Flags

(blocking-b2g:tef+, firefox21 wontfix, firefox22 wontfix, firefox23 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

Details

(Whiteboard: QARegressExclude)

Attachments

(1 attachment, 1 obsolete attachment)

/share/code/mozbuild/mozilla-central/dom/bluetooth/BluetoothUnixSocketConnector.cpp: In member function ‘virtual bool mozilla::dom::bluetooth::BluetoothUnixSocketConnector::SetUp(int)’:
/share/code/mozbuild/mozilla-central/dom/bluetooth/BluetoothUnixSocketConnector.cpp:127:50: error: invalid conversion from ‘int*’ to ‘socklen_t* {aka unsigned int*}’ [-fpermissive]
/usr/include/x86_64-linux-gnu/sys/socket.h:190:12: error:   initializing argument 5 of ‘int getsockopt(int, int, int, void*, socklen_t*)’ [-fpermissive]

Came in with bug 823803. Thought we were building desktop on tbpl, but guess not.
Created attachment 737604 [details] [diff] [review]
Patch 1 (v1) - Change sockopt length to be a socklen_t

Changed type, also removed sizeof because we set the optlen in the getsockopt call right after it.
Attachment #737604 - Flags: review?(echou)
Created attachment 737605 [details] [diff] [review]
Patch 1 (v2) - Change sockopt length to be a socklen_t

Oops. Forgot that we needed the initial struct size in getsockopt, so readded sizeof. :)
Attachment #737604 - Attachment is obsolete: true
Attachment #737604 - Flags: review?(echou)
Attachment #737605 - Flags: review?(echou)
Marking tef+ because bug 823803 was uplifted already.
blocking-b2g: --- → tef?
Comment on attachment 737605 [details] [diff] [review]
Patch 1 (v2) - Change sockopt length to be a socklen_t

Review of attachment 737605 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #737605 - Flags: review?(echou) → review+

Updated

5 years ago
blocking-b2g: tef? → tef+

Updated

5 years ago
Whiteboard: [status: needs landing]
https://hg.mozilla.org/mozilla-central/rev/14810c6f3dde
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [status: needs landing]

Updated

5 years ago
status-b2g18: --- → affected
status-b2g18-v1.0.1: --- → affected
https://hg.mozilla.org/releases/mozilla-b2g18/rev/2a03e41195bc
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6d338a0f8c95
status-b2g18: affected → fixed
status-b2g18-v1.0.0: --- → wontfix
status-b2g18-v1.0.1: affected → fixed
status-firefox21: --- → wontfix
status-firefox22: --- → wontfix
status-firefox23: --- → fixed
Can you please provide steps to verify this fix - as we will blackbox test from the UI?
Flags: needinfo?
This is tested by the sheer fact that it compiles at all. :)
Flags: needinfo?
Marking as QARegressExclude
Whiteboard: QARegressExclude
You need to log in before you can comment on or make changes to this bug.