If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

mozfile.extract fails when dest isn't specified

RESOLVED FIXED

Status

Testing
Mozbase
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
This is because we do os.path.isfile(dest) right after we set it to None by default:
https://github.com/mozilla/mozbase/blob/master/mozfile/mozfile/mozfile.py#L67
(Assignee)

Comment 1

5 years ago
Created attachment 737609 [details] [diff] [review]
Patch 1.0 - fix
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Attachment #737609 - Flags: review?(wlachance)
Comment on attachment 737609 [details] [diff] [review]
Patch 1.0 - fix

lgtm
Attachment #737609 - Flags: review?(wlachance) → review+
(Assignee)

Comment 3

5 years ago
https://github.com/mozilla/mozbase/commit/6c32b2609247cffc9aaede35d7c2ef106fb2fcae
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.