862061 - [SMS][MMS] contacts without a phone number entry will break the contacts lookup in the Sms app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Rick Waldron [:rwaldron]]

Seems serious.

Comment 1

[Julien Wajsberg [:julienw]]

ok, Bugzilla swallowed my description. And your first comment was made a description...

Let me write it again...

Comment 2

[Julien Wajsberg [:julienw]]

STR:
* Have 3 contacts: Julian, Julie and Juliette. Julian and Juliette only have a phone number, but not Julie.
* From the Sms App, look up "Juli"

Expected:
* we get all the contacts that have a phone number, that is Julian and Juliette.

Actual:
* Only Julian shows up.

And what shows up too is a logcat error :

E/GeckoConsole( 2982): [JavaScript Error: "TypeError: tels is null" {file: "app://sms.gaiamobile.org/js/thread_ui.js" line: 930}]

Seems both serious and easy to fix so requesting tef+ here.

Comment 3

[Julien Wajsberg [:julienw]]

note: I tested on v1-train and master. This is not related to the recent changes because the failing line exists since August 2012.

Comment 4

[Rick Waldron [:rwaldron]]

Attachment: Fix for 862061

Comment 5

[Rick Waldron [:rwaldron]]

Wait, hold off on this... looks like the problem existed in more then one place

Comment 6

[Rick Waldron [:rwaldron]]

@Julien this is good to go for review now

Comment 8

[Julien Wajsberg [:julienw]]

Comment on attachment 737669 [details] [review]
Fix for 862061

r=me with the nit

ping me on the PR or with NEEDINFO when you're ready to merge (squash rebase and everything)

Comment 9

[Julien Wajsberg [:julienw]]

master: df823b637aabc4c7df28dc0ed3a09689e842da28

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

This bug was partially uplifted.

Uplifted 862061 to:
v1-train: 24e818186cc9ab4e89783c6240c2003c36124387

Commit df823b637aabc4c7df28dc0ed3a09689e842da28 didn't uplift to branch v1.0.1

Comment 11

[Julien Wajsberg [:julienw]]

Rick, would you please try to fix the conflicts on 1.0.1 and push this on a branch in your repository ?

Comment 12

[Julien Wajsberg [:julienw]]

Rick, probably we'll need another completely different patch for landing on v1.0.1, because v1.0.1 does not have any of your changes to the contact search feature... Let's keep it as minimal as possible please :)

Comment 13

[Rick Waldron [:rwaldron]]

@Julien, that seems like an incredibly bad idea. It will result in worse conflicts...

Comment 14

[Rick Waldron [:rwaldron]]

The tests cannot be ported, as they rely on all of the test fixtures/mock as they appear in master.

Comment 15

[Rick Waldron [:rwaldron]]

@julienw https://github.com/mozilla-b2g/gaia/pull/9251

Comment 16

[Sreenidhi]

Issue not occuring in Inari with the following build :

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6bac24e14538
Gaia   c883af5ecd0998f78d9aaa4c2337c842e1dbb5a0
BuildID 20130416070200
Version 18.0

Comment 17

[Julien Wajsberg [:julienw]]

(In reply to Rick Waldron from comment #13)
> @Julien, that seems like an incredibly bad idea. It will result in worse
> conflicts...

at one point we want to have a stable branch and not uplift big patches ;)

Comment 18

[Borja Salguero [:borjasalguero]]

Regarding the patch I've seen it's surgical for v1.0.1. Please add the comment requested and we could land  this. 
Please add your patch here as well and mark it as 'Patch for v1.0.1' in order to track it properly and give my R+. Thanks!

Comment 19

[Daniel Coloma:dcoloma]

James, can we land this in v1.0.1. Thanks!

Comment 20

[Julien Wajsberg [:julienw]]

I'll add the comment requested by Borja and land it.

Comment 21

[Julien Wajsberg [:julienw]]

v1.0.1: 728fcbc5cd741083880d79fe74a84654696e618a

I also fixed the contact lookup that was probably broken since ages in v1.0.1 (an undeclared variable), I don't know why QA didn't catch this one.

Comment 22

[pallavi]

This issue is not reproducing. Verified and fixed on Inari
Inari Build ID:20130429070204
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/45aa5ba0ed53
Gaia: cf2d4136f0ebc66039637fdbeb72ed184dfbc0f2

This issue is not reproducing. Verified and fixed on Leo
Leo Build ID: 20130426070204
Kernel Date: Mar 15
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6c2493de1441
Gaia: c9046a7acef33328977840176ff5574720d2c74c