862073 - listTabs request should use a live list

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Jim Blandy :jimb]

Attachment: Document tabListChanged notification.

When the remote debugging protocol's root actor sends a "listTabs" reply, it should notify the client if the list of tabs subsequently changes. Suggested protocol documentation change attached (legible when viewed with 'Review').

(This will mesh nicely with the implementation of the child process list, which is also meant to be live.)

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

The spec change looks good to me.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Don't we do this by now? Can this be closed?

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

This is now implemented, but Jim needs to merge the doc change. I don't see it on GitHub:

https://github.com/jimblandy/DebuggerDocs/blob/master/protocol

Comment 4

[Eddy Bruel [:ejpbruel]]

Jim, have you updated the docs for this? I would like to be able to close this bug.

Comment 5

[Jim Blandy :jimb]

Comment on attachment 737680 [details] [diff] [review]
Document tabListChanged notification.

Oh, Panos has already looked it over. No need for further review.

Comment 6

[Jim Blandy :jimb]

Attachment: Document tabListChanged notification.

Slightly revised since the version Panos looked over, so requesting a fresh review.

This version documents present reality as described by jryans on IRC: we don't notify the client if a tab is merely navigated.

Comment 7

[Dave Camp (:dcamp)]

As an aside, it might be nice to describe the "only one change notification for an arbitrary number of changes between requests" pattern in the "Common communication patterns" section.

Comment 8

[Jim Blandy :jimb]

Pushed to https://github.com/jimblandy/DebuggerDocs:
commit f3fa3c1118ce9ef9900feb2c602ca8f2ac6e1210

Comment 9

[Eddy Bruel [:ejpbruel]]

(In reply to Jim Blandy :jimb from comment #8)
> Pushed to https://github.com/jimblandy/DebuggerDocs:
> commit f3fa3c1118ce9ef9900feb2c602ca8f2ac6e1210

Thank you for resolving this so quickly Jim!

Comment 10

[Jim Blandy :jimb]

(In reply to Dave Camp (:dcamp) from comment #7)
> As an aside, it might be nice to describe the "only one change notification
> for an arbitrary number of changes between requests" pattern in the "Common
> communication patterns" section.

Totally. Filed as bug 1071705.