Closed Bug 862121 Opened 12 years ago Closed 11 years ago

Users with numeric usernames break some AMO features, making them difficult to pinpoint

Categories

(addons.mozilla.org Graveyard :: Collections, defect)

Product:
addons.mozilla.org Graveyard
Component:
Collections
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2013-04-25

People

(Reporter: jorgev, Unassigned)

Details

(Whiteboard: [spampocalypse])

Here are some examples of collections that were created by spam users: https://addons.mozilla.org/collections/628212541663/ https://addons.mozilla.org/collections/34772198/ https://addons.mozilla.org/collections/6523114/ https://addons.mozilla.org/collections/329102/ These accounts were already deleted, but the collections continue to appear on listings, many days after the accounts were deleted. Other collections were correctly deleted along with their creators. We should at least delete all orphaned collections, to clean up all the spam.
Surprise! Those are not IDs, they are usernames. URL resolution for /collections/ uses usernames only; URL resolution for /user/ treats it as a user ID if it's numeric. So the link to the user profile page won't actually resolve to the creator's account. So for these collections, see: https://addons.mozilla.org/user/6843762/ https://addons.mozilla.org/user/6914654/ https://addons.mozilla.org/user/6914454/ https://addons.mozilla.org/user/6932928/
I'll try to delete those users, thanks. So, the bug here is that the username resolution is broken for numeric usernames and pointing to the wrong users, correct?
Right. Or that we should not allow all-numeric usernames, since it results in this ambiguity.
Summary: Spam collections lingering after users have been deleted → Users with numeric usernames break some AMO features, making them difficult to pinpoint
Whiteboard: [spampocalypse]
Disallowing numeric usernames seems kinda weird but I don't think it's a big concern and I think changing the behavior of the /user/ lookup at this point would have larger repercussions. To close this bug, let's simply disallow new numeric usernames. If we need to change existing usernames at some point, we can do that in another bug.
https://github.com/mozilla/olympia/commit/8f92f09f Creating a user with an all-digit username is now disallowed.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.