86217 - javascript strict warnings in sendProgress.js

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Henrik Gemal]

Warning: reference to undefined property dialog.strings[stringId]
Source File: chrome://messenger/content/messengercompose/sendProgress.js
Line: 130

build 20010615

Comment 1

[Henrik Gemal]

Please add the following line to your prefs.js file, so we could avoid all the 
strict warning fixup...:
user_pref("javascript.options.strict", true);

Comment 2

[Jean-Francois Ducarroz]

over to varada

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

->me.  I have a patch to fix.

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: 2 line patch to remove JS strict warnings

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Looking for r= so I can get sr=

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

BTW, I took out the return on the window.setTimeout statement because there was
a warning about onLoad() not always returning a value.  We don't do anything
with the returned value from window.setTimeout() whose purpose is just to set
the timeout as commented anyway so that should not matter.

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

As simple as that patch looks, I'm not the one to review it.  Varada will have
to do this.

Comment 8

[Doron Rosenberg (IBM)]

patch looks fine, but I think you need component owner review for this

Comment 9

[Håkan Waara]

Comment on attachment 53451 [details] [diff] [review]
2 line patch to remove JS strict warnings

r=hwaara

Comment 10

[varada]

Comment on attachment 53451 [details] [diff] [review]
2 line patch to remove JS strict warnings

r=varada

Comment 11

[(not reading, please use [e-mail] instead)]

Comment on attachment 53451 [details] [diff] [review]
2 line patch to remove JS strict warnings

sr=sspitzer

Comment 12

[Christopher Aillon (sabbatical, not receiving bugmail)]

Timeless checked this in for me a few days ago.

Comment 13

[Sheela Ravindran]

assigning to stephen since this is a code fix.  Thanks Stephend

Comment 14

[[e-mail] (gone - use [e-mail] instead)]

Yup, this is fixed.

Verified, build 2001-11-14, all OSs.