862310 - E.me missing network progress indication

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Ran Ben Aharon [:ranbena] EverythingMe]

When a Server API response lingers, there should be a progress indication.

Comment 1

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Screenshot - Indicator in action

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Redirect to PR #9205

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):
String or UUID changes made by this patch:

Comment 3

[Joey Simhon]

Wanted to add some context to this change:

During user testing with a not-so-operating WiFi users needed to wait for results a lot longer than usual and there was no indication that something was happening, which means a frustrating experience to our users.

We modified internal everything.me code only in this PR and risk is limited. 
We've tested it internally and we're also committed to immediately fix anything that rise due to it.

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

Merged to master https://github.com/mozilla-b2g/gaia/commit/e3696dee033b6c0d8f77ebb59b99c3f29b6ff79e

Comment 5

[Daniel Coloma:dcoloma]

Based on comment 3 and the expected connectivity for target markets I'd like to take this for 1.0.1

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

If the code has landed let's just close this bug.

Comment 7

[Ran Ben Aharon [:ranbena] EverythingMe]

John, should I merge it in?

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Ran Ben Aharon (Everything.me) from comment #7)
> John, should I merge it in?

I'll uplift this patch with the next group of uplifts.

Comment 9

[James Lal [:lightsofapollo]]

I was not able to uplift this bug to v1-train and v1.0.1.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train and v1.0.1, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 e3696dee033b6c0d8f77ebb59b99c3f29b6ff79e
  <RESOLVE MERGE CONFLICTS>
  git commit
  git checkout v1.0.1
  git cherry-pick -x $(git log -n1 v1-train --pretty=%H)

Comment 10

[Evyatar 'Tron' Amitay (everything.me)]

v1-train:
the conflict was very minor (practically just moved a few vars around), resolved and pushed
https://github.com/mozilla-b2g/gaia/commit/5cbb19e4bb78a7ad879fbe4b9a841e1c35714f5c

v1.0.1:
was a bit more complicated than v1-train, but no additional code was introduced.
https://github.com/mozilla-b2g/gaia/commit/f48c0a043384e510b8895c6a597e3bdd37f427f7

please let me know if it's all good

Comment 11

[James Lal [:lightsofapollo]]

Right commits on right branch uplift part looks good to me... Marking the correct flags to indicate successful uplift.

Thanks!

Comment 12

[pallavi]

Can't see any progress indication when the network is slow.There was only a loading symbol displayed.
Can you please provide steps to verify this fix as we will black box test from the UI?
Could you also attach an image of what the change should look like.

Comment 13

[Evyatar 'Tron' Amitay (everything.me)]

We called the loading symbol "progress indicator" :) It's not really indicative of the progress itself, just that there IS progress!

Comment 14

[pallavi]

Issue is not reproducing on Inari. Network Progress indicator is showing up on E.me

Inari Build ID: 20130502070201
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/5c1d67e0c242
Gaia: 11477c127ae9be5051e4cfbcbf3da1d4150f9967 

Issue is not reproducing on Leo. Network Progress indicator is showing up on E.me

Leo Build ID: 20130501070205
Kernel Date: Apr 25
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/765d296cff66
Gaia: e420d71c9528786621f176fb4ce67d291e0a530e