862338 - contacts settings Done button not working after activating "Order by last name"

Status: VERIFIED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Florin Strugariu [:Bebe]]

STR:
1. Add multiple contacts to phone 
2. check the contacts are ordered corecttly
3. open settings menu
4. activate "order by last name" option
5. Tap Done

Expected:
5. after taping the done button we should return to the coontacts menu and contacts should beorderd by last name

Actual:
5. Tapping done has no effect. Also there is no output in logcat

This was found by 
http://qa-selenium.mv.mozilla.com:8080/job/b2g.unagi.gaia.v1-train.ui/520/testReport/%28root%29/TestContacts/test_sort_contacts/

Comment 1

[Jose Manuel Cantera]

this is broken on v1-train and v1.0.1 but not in master

gonna investigate

Comment 2

[Jose Manuel Cantera]

Attachment: Pointer to GH PR #9231

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Bebe, when you (and others from the team file), can you please include 1) the Gecko and Gaia commit hashes (with branch for Gecko)?  They can be found in /b2g-distro/sources.xml

Thanks!

Like so:

Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6bac24e14538
Gaia: 2d048a9bdae54e4ec7d48326c2130591c8b869b6

Comment 4

[Chris Kreinbring [:CKreinbring]]

Attachment: Screenshot of contact list before and after

A few more details about this bug:

The Done button does work again after the "Order by last name" switch is tapped a second time.  However, the contact list will be blank when the user is returned to it.  The user will have to long-tap Home then close and relaunch Contacts in order to view their contacts again.  A screenshot of this is attached.

This also provides for a workaround.  After the user first taps the "Order by last name" switch, long-tap the Home button then close the app.  When Contacts is relaunched, the contacts will be listed in the new order.

Comment 5

[Andrew Overholt [:overholt]]

FWIW this seems to be a regression since at least 3e7dda889.

Comment 6

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/dbc79d071a356d2c770e7a20455f730ca4668dd0

Comment 8

[James Lal [:lightsofapollo]]

I was not able to uplift this bug to v1-train and v1.0.1.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train and v1.0.1, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 dbc79d071a356d2c770e7a20455f730ca4668dd0
  <RESOLVE MERGE CONFLICTS>
  git commit
  git checkout v1.0.1
  git cherry-pick -x $(git log -n1 v1-train --pretty=%H)

Comment 9

[Jose Manuel Cantera]

v1.0.1 

https://github.com/mozilla-b2g/gaia/commit/a212d9861c143d9b5aba3882c842db8397d0b6a8

v1-train

https://github.com/mozilla-b2g/gaia/commit/3cdab45a783efadf9b97decf46bd15b83fb91ed8

Comment 10

[bov]

Tested with BUILD:
unagi-ICS.user.manifest.V1.0.1.Rel0.4.Sprint8.B-115.Gecko-9b8d425.Gaia-a893d3f

STR:
1. Add multiple contacts to phone 
2. check the contacts are ordered corecttly
3. open settings menu
4. activate "order by last name" option
5. Tap Done

Expected:
5. after taping the done button we should return to the contacts menu and contacts should be ordered by last name

Actual:
5. Tapping done we return to the contacts menu and contacts are ordered by last name