862351 - [CONTACTS] Backend is sending us duplicate (or triplicate some times) contacts

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Florin Strugariu [:Bebe]]

STR:
1. open dialer
2. dial number
3. tap add contact
4. enter contact name
5. save
6. open contacts tab 

Expected:
6. The contact is added

Actual:
6. 2 exactly the same (duplicate) contacts are added in to contacts

This was found by:
http://qa-selenium.mv.mozilla.com:8080/job/b2g.unagi.gaia.v1-train.ui/520/testReport/%28root%29/TestDialerAddContact/test_dialer_add_contact/

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Taking a look to this.

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

We have been looking to this and the first impression is that backend is sending us the contacts duplicated (or triplicated) when using the cursor.

Asking our colleagues from backend to confirm this.

Thanks

Comment 3

[Reuben Morais [:reuben]]

I can't reproduce this on b2g18 + Gaia master, and I can't see anything in the backend code that looks like it could be causing this. I also just landed tests to getall that should make sure we don't do this (as long as it happens in desktop as well).

Francisco, as we discussed, please flag me again if you can reproduce this in an updated build.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Flagging again Reuben :)

We both saw on the device how we were getting triple contacts when asking the backend.

Thanks!

Comment 5

[Angela Hubenya]

I am experiencing the same issue.
I also cannot add any contacts that start with the same letter as the contacts that got tripled. 

A separate bug has been logged for that issue. Bug 863017

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Rewording the bug title as may lead to errors.

Comment 7

[Reuben Morais [:reuben]]

Yes, this is an API bug, taking.

Comment 8

[Reuben Morais [:reuben]]

Attachment: Don't enqueue messages sent to a different inner window

Comment 9

[Gregor Wagner [:gwagner]]

Comment on attachment 739124 [details] [diff] [review]
Don't enqueue messages sent to a different inner window

Review of attachment 739124 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/contacts/ContactManager.js
@@ +474,5 @@
> +              debug(result[i].name);
> +            } else {
> +              debug("null contact");
> +            }
> +          }

Remove!

Comment 10

[Reuben Morais [:reuben]]

https://hg.mozilla.org/projects/birch/rev/d1847d734c77

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d1847d734c77

Comment 12

[Reuben Morais [:reuben]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/5044b1c63922
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/f722db15bab4

Comment 14

[Angela Hubenya]

Contacts are not duplicated nor triplicated when added to address book 

Unagi
Build ID: 20130501070205
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/765d296cff66
Gaia: e420d71c9528786621f176fb4ce67d291e0a530e