862365 - B2G MMS: Support auto-home in retrieve mode(follow-up fixed).

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

In roaming situation, rilContext.data.roaming will be false if you don't enable data roaming. So we need to change to get rilContext.voice.roaming value instead.

Comment 1

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

This is a follow-up leo+ bug fix.

Comment 2

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 738035 [details] [diff] [review]
Patch v1

Review of attachment 738035 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mms/src/ril/MmsService.js
@@ +1168,5 @@
>  
> +    let isRoaming = gMmsConnection.isVoiceRoaming();
> +    // In roaming environment, we send notify response only in
> +    // automatic retrieval mode.
> +    if (isRoaming && retrievalMode !== RETRIEVAL_MODE_AUTOMATIC) {

if ((retrievalMode !== RETRIEVAL_MODE_AUTOMATIC) &&
      gMmsConnection.isVoiceRoaming())

So that we only create gMmsConnection when necessary.

Comment 4

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Patch v1.1

Comment 5

[Kai-Chih Hu [:khu]]

This looks like a leo+ to me.

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/projects/birch/rev/c524665e9f3e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c524665e9f3e

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

Uplift WIP: https://github.com/vicamo/b2g_mozilla-central/tree/bugzilla/838467/b2g18 , verifying.

Comment 9

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/f7fc76b6fa84