B2G MMS: Support auto-home in retrieve mode(follow-up fixed).

RESOLVED FIXED in Firefox 23

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ctai, Assigned: ctai)

Tracking

unspecified
mozilla23
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph
Bug Flags:
in-moztrap -

Firefox Tracking Flags

(blocking-b2g:leo+, firefox21 wontfix, firefox22 wontfix, firefox23 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix)

Details

(Whiteboard: [fixed-in-birch])

Attachments

(1 attachment, 1 obsolete attachment)

In roaming situation, rilContext.data.roaming will be false if you don't enable data roaming. So we need to change to get rilContext.voice.roaming value instead.
Summary: B2G MMS: B2G MMS: Support auto-home in retrieve mode(follow-up fixed). → B2G MMS: Support auto-home in retrieve mode(follow-up fixed).
This is a follow-up leo+ bug fix.
blocking-b2g: --- → leo?
Whiteboard: [NO_UPLIFT]
Posted patch Patch v1 (obsolete) — Splinter Review
Attachment #738035 - Flags: review?(vyang)
Comment on attachment 738035 [details] [diff] [review]
Patch v1

Review of attachment 738035 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mms/src/ril/MmsService.js
@@ +1168,5 @@
>  
> +    let isRoaming = gMmsConnection.isVoiceRoaming();
> +    // In roaming environment, we send notify response only in
> +    // automatic retrieval mode.
> +    if (isRoaming && retrievalMode !== RETRIEVAL_MODE_AUTOMATIC) {

if ((retrievalMode !== RETRIEVAL_MODE_AUTOMATIC) &&
      gMmsConnection.isVoiceRoaming())

So that we only create gMmsConnection when necessary.
Attachment #738035 - Flags: review?(vyang) → review+
Posted patch Patch v1.1Splinter Review
Attachment #738035 - Attachment is obsolete: true
This looks like a leo+ to me.
https://hg.mozilla.org/projects/birch/rev/c524665e9f3e
Whiteboard: [NO_UPLIFT] → [NO_UPLIFT] [fixed-in-birch]
https://hg.mozilla.org/mozilla-central/rev/c524665e9f3e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
blocking-b2g: leo? → leo+
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.