862368 - Implement HTML version of new thread and new post emails (contributor forum)

Status: RESOLVED FIXED

(support.mozilla.org :: Forum, task, P2)

Description

[Ricky Rosario [:rrosario, :r1cky]]

Let's start by adding HTML version of the contributor forum emails. It's a low risk email if something goes wrong and contributors are great at giving us quick feedback.

The two emails are:
apps/forums/templates/email/new_post.ltxt
apps/forums/templates/email/new_thread.ltxt

We'll be using the base template implemented in bug 855299

Comment 1

[Kadir Topal [:atopal]]

Michael, your input for the copy is appreciated

Comment 2

[Verdi [:verdi] Best to slack me]

What are the full urls to the current text?

Comment 3

[Rehan Dalal (Inactive)]

You can check out the current text here:
https://github.com/mozilla/kitsune/blob/master/apps/forums/templates/forums/email/new_post.ltxt
https://github.com/mozilla/kitsune/blob/master/apps/forums/templates/forums/email/new_thread.ltxt

I assumed the copy would be the same for the HTML and plain-text version.

Comment 4

[Kadir Topal [:atopal]]

It can't be exactly the same as we say things like: "Click the following link", which makes sense when you have to display the actual URL. 
But we can do better now :)

Comment 5

[Rehan Dalal (Inactive)]

Makes sense! I'm ready to implement this. I just need to know what the copy is.

Comment 6

[Verdi [:verdi] Best to slack me]

For these two messages I think we only need to change the line at the end from:
* To view this post on the site, click the following link, or
paste it into your browser's location bar:

to a link that says:
* View this message on the site

Comment 7

[Rehan Dalal (Inactive)]

Landed:
https://github.com/mozilla/kitsune/commit/5145ebdb13319c386f5d009be6326517bf6f134d

Pushed to prod by me, right now.

Comment 8

[Verdi [:verdi] Best to slack me]

Attachment: broken image link

The images in the email I received are broken. Looks like "http:" is missing from the src attribute.

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

Rehan fixed the urls:
https://github.com/mozilla/kitsune/commit/25e1a2087f49291a6b55be0ce9867acb992eb84d
https://github.com/mozilla/kitsune/commit/57f494f27eca25228a49bcc26f5d28a9f390ac26

I'll land now. 

There might be other issues with images like that because of lazy loading. We should probably open new bugs for those.

Comment 10

[Ricky Rosario [:rrosario, :r1cky]]

I deployed Rehan's fixes for incomplete URLs. I am pretty sure images will still be broken in some way. Filed Bug 867129 to figure out what to do with lazy loaded images.