862411 - Implement an IDL checking hook on mozilla-b2g18* for RIL-impacting interface changes

Status: RESOLVED WONTFIX

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Alex Keybl [:akeybl]]

Cloning for a B2G hook, only checking these idl files:

 content/base/public/nsIMessageManager.idl
 dom/interfaces/settings/nsISettingsService.idl
 dom/messages/interfaces/nsISystemMessagesInternal.idl
 dom/mobilemessage/interfaces/nsIDOMSmsMessage.idl
 dom/mobilemessage/interfaces/nsIMobileMessageCallback.idl
 dom/mobilemessage/interfaces/nsIRilMobileMessageDatabaseService.idl
 dom/mobilemessage/interfaces/nsISmsService.idl
 dom/system/gonk/nsIAudioManager.idl
 dom/system/gonk/nsIRadioInterfaceLayer.idl
 dom/time/nsITimeService.idl
 xpcom/system/nsIGeolocationProvider.idl

+++ This bug was initially created as a clone of Bug #813809 +++

The attached hook looks at any files ending in .idl in a push and scans the changes for 'uuid(' - if found, the user is warned and their push is rejected if they do not have binary approval (ba=...) in the tip commit comment.

The tests pass except checking that if deleting a file with a uuid in it is found for approval. I would love a second pair of eyes on that one (on top of the whole deal).

Once the hook is reviewed and approved it will need to be installed on our hg server as a pretxnchangegroup hook (same as treeclosure) on mozilla-beta and mozilla-release repos only.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: Hook to watch specific B2G IDL files

Mostly a straight-up copy of the other IDL hook, but checks against a hardcoded list of files we know to watch for that could affect B2G.

Tests pass.

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 766109 [details] [diff] [review]
Hook to watch specific B2G IDL files

Michael - does this list of files look complete to you?  Any additions?

Comment 3

[Anshul]

Alex, I am assuming this change is for Moz central, so please find the additional files that we care about.

{"nsIDOMMozCellBroadcastMessage", NS_IDOMMOZCELLBROADCASTMESSAGE_IID},
{"nsIDOMMozMobileCellInfo", NS_IDOMMOZMOBILECELLINFO_IID},
{"nsIDOMMozMobileConnectionInfo", NS_IDOMMOZMOBILECONNECTIONINFO_IID},
{"nsIDOMMozMobileNetworkInfo", NS_IDOMMOZMOBILENETWORKINFO_IID},
{"nsIDOMMozSmsSegmentInfo", NS_IDOMMOZSMSSEGMENTINFO_IID},
{"nsIICCRecords", NS_IICCRECORDS_IID},
{"nsIMobileMessageService", NS_IMOBILEMESSAGESERVICE_IID},
{"nsINetworkInterface", NS_INETWORKINTERFACE_IID},
{"nsINetworkManager", NS_INETWORKMANAGER_IID},
{"nsIRILDataCallInfo", NS_IRILDATACALLINFO_IID},
{"nsIRILDataCallback", NS_IRILDATACALLBACK_IID},
{"nsIRilContext", NS_IRILCONTEXT_IID},
{"nsIRilMobileMessageDatabaseCallback", NS_IRILMOBILEMESSAGEDATABASECALLBACK_IID},
{"nsIVoicemailInfo", NS_IVOICEMAILINFO_IID},

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 766109 [details] [diff] [review]
Hook to watch specific B2G IDL files

Review of attachment 766109 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozhghooks/prevent_uuid_changes_b2g.py
@@ +19,5 @@
> +to specific .idl files in the b2g codebase
> +"""
> +import re
> +
> +FILES = [

nit: could use FILES = set([...])

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Bhavana, is this still needed for b2g branches?

Comment 6

[bhavana bajaj [:bajaj]]

(In reply to Lukas Blakk [:lsblakk] use ?needinfo from comment #5)
> Bhavana, is this still needed for b2g branches?

We were trying to do this for RIL impacting files, so this is not urgent but will be a nice to have. I can assign it to myself and help out here where when I have a chance int he next few weeks.

Comment 7

[Gregory Szorc [:gps]]

Is this still needed? If so, perhaps the bug summary could be updated to not reflect b2g18.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Mass closing as we are no longer working on b2g/firefox os.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Mass closing as we are no longer working on b2g/firefox os.