862421 - [Cost Control] Remove hardcoded ellipsis dots (…) and add them to l10n files

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Salvador de la Puente González [:salva]]

There are two samples of ellipsis dots (…) hardcoded in the sources:
https://github.com/mozilla-b2g/gaia/blob/master/apps/costcontrol/js/views/balance.js#L283
https://github.com/mozilla-b2g/gaia/blob/master/apps/costcontrol/js/widget.js#L371

They should be in the l10n files.

Comment 1

[Salvador de la Puente González [:salva]]

Attachment: Remove harcoded ellipsis and add them to locales

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 738952 [details]
Remove harcoded ellipsis and add them to locales

Nice, quick and easy one.

Thanks Salva now it makes more natural to me see the code without those appends.

Cheers!

Comment 3

[Salvador de la Puente González [:salva]]

Master: f953868fef198c6cb7640e7ecdcc8f34c3262780

Comment 4

[Salvador de la Puente González [:salva]]

Comment on attachment 738952 [details]
Remove harcoded ellipsis and add them to locales

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 859898
User impact if declined: low
Testing completed: yes
Risk to taking this patch (and alternatives if risky): very low
String or UUID changes made by this patch: new strings

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

Lukas, you marked this as status-b2g18:fixed a while ago.  This doesn't look like it's been uplifted.  Is this the correct status?

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Yup, that looks like a slip of the hand when doing tracking-b2g18+ and marking 'affected' - adjusting.

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 738952 [details]
Remove harcoded ellipsis and add them to locales

Approving for landing on v1.1 - this is correctly a new string.

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 f953868fef198c6cb7640e7ecdcc8f34c3262780
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 9

[Salvador de la Puente González [:salva]]

After merging bug 841294 and bug 859898, this applies cleanly.

v1-train: 1bac83700810f27e00a937e34e7c865da02e0215