Closed Bug 862446 Opened 8 years ago Closed 8 years ago

Use CallArgs in XPC_WN_Helper_{Call,Construct}

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla23

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(1 file)

Patch v1
5.16 KB, patch
bholley
: review+
Waldo
: feedback+
Details | Diff | Splinter Review
Attached patch Patch v1 — — Splinter Review 
No description provided.
Attachment #738088 - Flags: review?(bobbyholley+bmo)
Comment on attachment 738088 [details] [diff] [review]
Patch v1

Review of attachment 738088 [details] [diff] [review]:
-----------------------------------------------------------------

r=bholley pending confirmation from Waldo that JSClass call/construct hooks pass argc and vp in a way that makes this appropriate.
Attachment #738088 - Flags: review?(bobbyholley+bmo)
Attachment #738088 - Flags: review+
Attachment #738088 - Flags: feedback?(jwalden+bmo)
Comment on attachment 738088 [details] [diff] [review]
Patch v1

Review of attachment 738088 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this is fine.  Actually the JS-engine-internal callers themselves have JS::CallArgs on hand, and they deconstruct it into .length() and .base() when calling these hooks.  :-\  But, one step at a time!
Attachment #738088 - Flags: feedback?(jwalden+bmo) → feedback+
https://hg.mozilla.org/mozilla-central/rev/a0dc62967961
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.