Closed Bug 862501 Opened 8 years ago Closed 5 years ago

Baseline (BC) should provide more accurate SP for better interleaving

Categories

(Core :: Gecko Profiler, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: BenWa, Assigned: djvj)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Right now the baseline pseudo entries are attached before RunScript. If we give better SP estimate they will get attached to their native JIT frames.

FYI: You might want to update the author field before landing
Attachment #738129 - Attachment is patch: true
Attachment #738129 - Flags: review?(jdemooij)
Attachment #738129 - Flags: review?(jdemooij) → review+
Ah, it seems that the presence of a NULL sp is used as an indicator of whether the frame is JS or not.

Talked to Benoit about it, he's busy with other stuff, and so am I so pushing this down the priority stack.
This bug is irrelevant after the changes to the profiling infrastructure to let the profiler walk jit stacks directly instead of needing a pseudostack.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.