Closed Bug 862562 Opened 7 years ago Closed 6 years ago

mozboot bootstrap fails on OS X 10.6

Categories

(Firefox Build System :: General, defect)

All
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla23

People

(Reporter: dave, Assigned: dave)

References

Details

Attachments

(1 file)

Using homebrew, osx.py executes:

if self.os_version < StrictVersion('10.7') and 'llvm' not in installed:
   print(HOMEBREW_OLD_CLANG)

But HOMEBREW_OLD_CLANG was never defined, so the script fails. The same problem exists with MACPORTS_OLD_CLANG.
This looks like it was introduced by the following commit: https://hg.mozilla.org/mozilla-central/rev/dd821b465e97
Another regression from bug 805811 :/

Fix is easy though. Do you want to do it?
Depends on: 805811
A couple of other related issues showed up as I fixed this. So the patch includes fixes for:

1. The original issue, where HOMEBREW_OLD_CLANG and MACPORTS_OLD_CLANG were undefined.
2. PACKAGE_MANAGER_PACKAGES is being printed without substitution, so we're printing a literal '%s'.
3. The 'llvm' package is no longer valid in MacPorts, we have to specify a clang-X.Y package instead. I chose clang-3.2, to match the tbpl builders.
4. MacPorts has binaries named 'clang-mp-3.2' and 'python2.7', so the build system doesn't find them when it looks for 'clang' and 'python'. We should use the 'port select' mechanism to make these aliases available.

I hope it's ok to put these together in one patch, I can split them out if needed.
Attachment #744694 - Flags: review?
Attachment #744694 - Flags: review? → review?(gps)
Comment on attachment 744694 [details] [diff] [review]
Allow mozboot to work on OS X 10.6

Review of attachment 744694 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me!

Thank you for fixing it. Do you need someone to check this in for you?
Attachment #744694 - Flags: review?(gps) → review+
Thanks for the review. I do need someone to check it in, ok to mark it checkin-needed?
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ba8cfb0179f1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.