Social provider jewel icons no longer change opacity when the window is inactive

VERIFIED FIXED in Firefox 22

Status

()

Firefox
SocialAPI
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: MattN, Assigned: mixedpuppy)

Tracking

({regression})

Trunk
Firefox 23
All
Mac OS X
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox22 verified, firefox23 verified)

Details

Attachments

(3 attachments)

Created attachment 738208 [details]
Screenshot of Facebook jewel icons not matching the style of others

When the browser window loses focus, toolbar buttons should fade out on OS X.  This stopped working recently for the provider-provided jewels. This still works for the main social toolbar button. See the screenshot of how much the social jewel icons stand out with this regression.

Some relevant CSS for OS X is https://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.css?rev=5e4ccad71f40&mark=465-477#465

I suspect this is caused by the change in bug 855389 but I could be wrong.  If so, then this is also on Aurora.
The fix for bug 855389 landed on mozilla-central on April 8, 2013. 
 * Firefox Nightly 23.0a1 2013-04-08 does not reproduce this bug
 * Firefox Nightly 23.0a1 2013-04-09 does reproduce this bug

That would seem to confirm that the fix for bug 855389 introduced this regression. It should come as no surprise then that I can also confirm the latest mozilla-aurora has this bug.
status-firefox22: ? → affected
(Assignee)

Comment 2

5 years ago
Created attachment 738709 [details] [diff] [review]
fix window inactive styling
Assignee: nobody → mixedpuppy
Attachment #738709 - Flags: review?(mnoorenberghe+bmo)
Comment on attachment 738709 [details] [diff] [review]
fix window inactive styling

Review of attachment 738709 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/osx/browser.css
@@ +456,5 @@
>    margin: 2px;
>  }
>  
>  .toolbarbutton-1[disabled="true"] > .toolbarbutton-icon,
> +.toolbarbutton-1[disabled="true"] > .toolbarbutton-badge-container > .toolbarbutton-icon,

It seems like it may be useful to use * instead of .toolbarbutton-badge-container so this would work for other containers but that can be changed later if we find it would be useful.
Attachment #738709 - Flags: review?(mnoorenberghe+bmo) → review+
(Assignee)

Comment 5

5 years ago
Comment on attachment 738709 [details] [diff] [review]
fix window inactive styling

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 855389
User impact if declined: some icons on toolbarbutton do not appear inactive when window is inactive
Testing completed (on m-c, etc.): manual
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none
Attachment #738709 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/1f96fa77e6a5
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23

Updated

5 years ago
status-firefox23: affected → fixed
(Assignee)

Updated

5 years ago
Depends on: 864894

Comment 7

5 years ago
Comment on attachment 738709 [details] [diff] [review]
fix window inactive styling

New regression, not necessarily worth tracking, but worth taking a fix given where we are in the cycle.
Attachment #738709 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Created attachment 742051 [details]
Screenshot

Tested Firefox Aurora 22.0a2 2013-04-25 and Firefox Nightly 23.0a1 2013-04-25.

The jewel icons now dim as expected but the red notification indicators are not. I think they should dim as well. Should this be done in this bug or a follow up bug?
(Assignee)

Comment 10

5 years ago
(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #9)
> Created attachment 742051 [details]
> Screenshot
> 
> Tested Firefox Aurora 22.0a2 2013-04-25 and Firefox Nightly 23.0a1
> 2013-04-25.
> 
> The jewel icons now dim as expected but the red notification indicators are
> not. I think they should dim as well. Should this be done in this bug or a
> follow up bug?

Bug 864894 is a followup to fix that for osx.  I have to also look at windows and linux to just make sure about the behavior.
Okay, thanks Shane. Marking this bug verified fixed.
Status: RESOLVED → VERIFIED
status-firefox22: fixed → verified
status-firefox23: fixed → verified
You need to log in before you can comment on or make changes to this bug.