862579 - [Browser] View URL Web Activity will open a new tab even if it doesn't need to

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P2)

Description

[Chris Kreinbring [:CKreinbring]]

Attachment: Screenshot of extra browser tab

Description:
If a user taps the User Guide button in the help page and doesn't have the browser open, the browser will open a second tab with no content as well as the Firefox Help tab.

Repro Steps:
1) Updated to Inari Build ID: 20130416070200
2) Select Settings then select Help.
3) Tap the User guild button and observe the app and page that launches.
4) Tap the tabs prompt in the upper right corner and observe the tabs that are listed.

Actual:
The Firefox Help tab is displayed below a blank new tab.

Expected:
The Firefox Help tab is displayed with no other tabs displayed.

Environmental Variables:
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/6bac24e14538
Gaia: c883af5ecd0998f78d9aaa4c2337c842e1dbb5a0

Notes:
Repro frequency: 100%
Q Analysts Test Team Priority: Pri 3
See attached screenshot for more info.

Comment 1

[Chris Kreinbring [:CKreinbring]]

Still repros on Inari 1.0.1 commercial RIL and Leo 1.1 mozilla RIL.

Inari Build ID: 20130503070205
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3f3489356bbc
Gaia: 3e232bce289c9e156d92553e752616cba284bc8f
Version #: 18.0

Leo Build ID: 20130503070204
Kernel Date: Mar 15
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8becaf2a0bc7
Gaia: b0aca0dd1e2955e11190ede725e1fb9ee596438b
Version #: 18.0

Comment 2

[Ben Francis [:benfrancis]]

This is because the web activity handler always creates a new tab and when the browser first starts it already has one tab open. We could tell it to use the first tab to view the URL if the current URL of that tab is null.

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Pointer to GH

Just a note to test there is a a page to launch a view url activity in the ui tests

Comment 4

[Ben Francis [:benfrancis]]

Comment on attachment 765708 [details]
Pointer to GH

r+me

Comment 5

[Ben Francis [:benfrancis]]

Merged into master https://github.com/mozilla-b2g/gaia/commit/2f48c92b086ebf2578ac0b6260e1ab67a1951d6d

Comment 6

[Chris Kreinbring [:CKreinbring]]

Still repros on Unagi 1.1 mozilla and Leo 1.1 commercial RILs.

Leo
Build ID: 20130719070225
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6b6e80e9aaf0
Gaia: ce5a75acd4ad6cd0d53dad77c058a0f1002f98b1
Platform Version: 18.1
RIL Version: 01.01.00.019.164 

Unagi
Build ID: 20130719070225
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6b6e80e9aaf0
Gaia: ce5a75acd4ad6cd0d53dad77c058a0f1002f98b1
Platform Version: 18.1

Comment 7

[Chris Kreinbring [:CKreinbring]]

A blank tab is still created on Leo 1.1 commercial RIL, but the Unagi 1.2 mozilla RIL only spawns one tab which contains the Firefox Help page.

Build ID: 20130816041203
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/09a8c5b6b287
Gaia: 6040508a535b587d4155356a47b22d7bd9ea4de7
Platform Version: 18.1
RIL Version: 01.01.00.019.190