Closed
Bug 862586
Opened 13 years ago
Closed 13 years ago
[webvtt] update parse to v0.4
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: rillian, Assigned: rillian)
Details
Attachments
(1 file)
|
93.07 KB,
patch
|
cpearce
:
review+
caitlin.potter
:
feedback+
|
Details | Diff | Splinter Review |
The webvtt parser library recently tagged v0.4, which passes all the unit tests. We should update the copy in firefox to match this milestone.
|
Assignee | |
Comment 1•13 years ago
|
||
Result of running the update script passing the v0.4 revision.
NB README_MOZILLA seems to pick up the tag id, rather than the tagged commit id. Don't know if that matters.
Assignee: nobody → giles
Attachment #738239 -
Flags: review?(cpearce)
Attachment #738239 -
Flags: feedback?(caitlin.potter)
|
||
Updated•13 years ago
|
Attachment #738239 -
Flags: review?(cpearce) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
|
||
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
||
Comment 4•13 years ago
|
||
(In reply to Ralph Giles (:rillian) from comment #1)
> NB README_MOZILLA seems to pick up the tag id, rather than the tagged commit
> id. Don't know if that matters.
This is a bug in the update script (Also, the script doesn't seem to work in non-bash shells currently, so that's another problem with the shebang line)
I'll submit a patch to fix this at some point :c
|
|
||
Comment 5•13 years ago
|
||
Comment on attachment 738239 [details] [diff] [review]
update to webvtt v0.4
Review of attachment 738239 [details] [diff] [review]:
-----------------------------------------------------------------
bit late I know :>
Attachment #738239 -
Flags: feedback?(caitlin.potter) → feedback+
You need to log in
before you can comment on or make changes to this bug.
Description
•