Closed Bug 862610 Opened 11 years ago Closed 11 years ago
Crash [@ mozilla::dom::HTMLImage
Element Binding::Define DOMInterface] with proto manipulation
No description provided.
This is fun. When we go to set up HTMLImageElement.prototype, the call to JS_DefineProperties ends up doing a LookupProperty (in js::DefineNativeProperty) which ends up doing ScriptedIndirectProxyHandler::getPropertyDescriptor on HTMLElement.prototype.__proto__ (which the testcase redefined to some random proxy with no handler), which of course throws. So JS_DefineProperties throws, we unwind to mozilla::dom::HTMLImageElementBinding::DefineDOMInterface, get a null interfaceObject, but never null-check it before starting to look for named constructor stuff.
Comment on attachment 738287 [details] [diff] [review] When we have named constructors, make sure we managed to set up an interface object before looking for them. [Approval Request Comment] Bug caused by (feature/regressing bug #): Bug 825628 User impact if declined: Possible to trigger near-null-dereference crashes Testing completed (on m-c, etc.): Passes attached test Risk to taking this patch (and alternatives if risky): Very low risk: simple null-check. String or IDL/UUID changes made by this patch: Nope.
On Windows: bp-8130bcaa-3d36-48b8-bbf2-e3cd42130417
Crash Signature: [@ mozilla::dom::HTMLImageElementBinding::DefineDOMInterface] → [@ mozilla::dom::HTMLImageElementBinding::DefineDOMInterface] [@ js::shadow::Object::slotRef(unsigned int)] [@ js::GetObjectClass(JSObject*)]
OS: Mac OS X → All
Hardware: x86_64 → All
Version: Trunk → 22 Branch
Attachment #738287 - Flags: review?(peterv) → review+
This crashtest fails crashtest-ipc due to bug 862825. I'll modify it to address that. I thought about this a bit more, and the js engine behavior here is just wrong. Filed bug 862848.
Attachment #738600 - Flags: approval-mozilla-aurora?
Comment on attachment 738600 [details] [diff] [review] With test that passes in our harnesses too quick on the approval, will wait for m-c landing.
Attachment #738600 - Flags: approval-mozilla-aurora+ → approval-mozilla-aurora?
Target Milestone: --- → mozilla23
Mozilla/5.0 (X11; Linux i686; rv:23.0) Gecko/20100101 Firefox/23.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20100101 Firefox/23.0 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0 Verified as fixed on Firefox 23 Beta 1 (buildID: 20130625125232) latest Aurora (buildID: 20130624004020) and latest Nightly (buildID: 20130625031238).
You need to log in before you can comment on or make changes to this bug.