862621 - SharedPlanarYCbCrImage.cpp:106:34: warning: unused variable 'shmType' [-Wunused-variable]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daniel Holbert [:dholbert]]

{
gfx/layers/ipc/SharedPlanarYCbCrImage.cpp: In member function 'virtual bool mozilla::layers::SharedPlanarYCbCrImage::Allocate(mozilla::layers::PlanarYCbCrImage::Data&)':

gfx/layers/ipc/SharedPlanarYCbCrImage.cpp:106:34: warning: unused variable 'shmType' [-Wunused-variable]

    SharedMemory::SharedMemoryType shmType = OptimalShmemType();
                                   ^
}

This code was added last week for bug 825928:
https://hg.mozilla.org/mozilla-central/diff/ee5ca214e87c/gfx/layers/ipc/SharedPlanarYCbCrImage.cpp#l1.110

Presumably this variable can just be dropped.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1: drop variable

Comment 2

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a48aafea3e0f

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a48aafea3e0f

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 738282 [details] [diff] [review]
fix v1: drop variable

Review of attachment 738282 [details] [diff] [review]:
-----------------------------------------------------------------

To be sure, calling OptimalShmemType() had no side effects?

Comment 5

[Daniel Holbert [:dholbert]]

Correct. That function has one definition, which lives here:
http://mxr.mozilla.org/mozilla-central/source/gfx/layers/ipc/ISurfaceAllocator.cpp#26

and it just returns an enum without changing anything.