Closed Bug 862621 Opened 6 years ago Closed 6 years ago

SharedPlanarYCbCrImage.cpp:106:34: warning: unused variable 'shmType' [-Wunused-variable]

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

{
gfx/layers/ipc/SharedPlanarYCbCrImage.cpp: In member function 'virtual bool mozilla::layers::SharedPlanarYCbCrImage::Allocate(mozilla::layers::PlanarYCbCrImage::Data&)':

gfx/layers/ipc/SharedPlanarYCbCrImage.cpp:106:34: warning: unused variable 'shmType' [-Wunused-variable]

    SharedMemory::SharedMemoryType shmType = OptimalShmemType();
                                   ^
}

This code was added last week for bug 825928:
https://hg.mozilla.org/mozilla-central/diff/ee5ca214e87c/gfx/layers/ipc/SharedPlanarYCbCrImage.cpp#l1.110

Presumably this variable can just be dropped.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #738282 - Flags: review?(bas)
Attachment #738282 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/a48aafea3e0f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Comment on attachment 738282 [details] [diff] [review]
fix v1: drop variable

Review of attachment 738282 [details] [diff] [review]:
-----------------------------------------------------------------

To be sure, calling OptimalShmemType() had no side effects?
Correct. That function has one definition, which lives here:
http://mxr.mozilla.org/mozilla-central/source/gfx/layers/ipc/ISurfaceAllocator.cpp#26

and it just returns an enum without changing anything.
You need to log in before you can comment on or make changes to this bug.