Closed
Bug 862625
Opened 13 years ago
Closed 13 years ago
Happy/Sad button in toolbar for Firefox desktop beta 21.0 goes to "Page Not Found" page
Categories
(Input :: General, defect, P1)
Input
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: aakashd, Assigned: willkg)
References
Details
(Whiteboard: u=user c=feedback p=1 s=input.2013q2)
Version: 21.0
Steps to Reproduce:
1. Click on the Feedback button
2. Click on "Firefox Made me Happy Because..."
Actual Results:
I'm redirected to https://input.mozilla.org/en-US/happy
Expected Results:
I'm redirected to https://input.mozilla.org/en-US/feedback#happy
Note:
Same thing happens for the "sad" button as well.
| Assignee | ||
Comment 1•13 years ago
|
||
Which Firefox are you using? Firefox for Android? Firefox desktop? Something else?
Where is the "Feedback button" that you're pressing?
| Reporter | ||
Comment 2•13 years ago
|
||
Firefox Desktop; it's on the navigation toolbar
| Assignee | ||
Comment 3•13 years ago
|
||
I don't see those buttons in nightly and I don't have beta installed, so I'll have to look into it later.
I'll put it in my queue for this week.
Assignee: nobody → willkg
Whiteboard: u=user c=feedback p= s=input.2013q2
| Reporter | ||
Comment 4•13 years ago
|
||
It might be worthwhile to look into this now. Not sure what the exact numbers are for the beta audience, but it affects all of them right now (the feedback add-on is shipped alongside the browser).
http://mxr.mozilla.org/mozilla-beta/source/browser/app/profile/extensions/
| Assignee | ||
Comment 5•13 years ago
|
||
If this is in an addon, then they should fix it there. Does the addon have a product/component in Bugzilla?
| Reporter | ||
Comment 7•13 years ago
|
||
Well, there's 1 of 2 ways to fix this:
1. The url in the add-on can be changed
2. redirect can be offered by input.mozilla.org for /happy and /sad to go to /feedback#happy and /feedback#sad
It's quicker and easier to change the links rather than push out a new version of the add-on. Might be worthwhile to add a follow-up bug in Firefox/General to change the urls permanently as well. My 2 cents.
| Assignee | ||
Comment 8•13 years ago
|
||
Created bug https://bugzilla.mozilla.org/show_bug.cgi?id=862844 for getting the urls fixed in the product.
I'll see what I can do about getting redirects added.
Comment 9•13 years ago
|
||
What add-on are we talking about, Aakash?
| Reporter | ||
Comment 10•13 years ago
|
||
The feedback add-on? It's the Test Pilot add-on that was coupled with feedback buttons for Input back in the Fx4 timeframe. Here's the link of where it resides in the browser code.
http://mxr.mozilla.org/mozilla-beta/source/browser/app/profile/extensions/
Jinghua might know more than I do now.
Comment 11•13 years ago
|
||
I installed Test Pilot from AMO and don't get that UI. It must be a special build for mozilla-beta?
| Reporter | ||
Comment 12•13 years ago
|
||
Yeah, its bundled with the browser. At least, it should be. Try using a new profile and downloading Fx Beta.
| Assignee | ||
Comment 13•13 years ago
|
||
PR: https://github.com/mozilla/fjord/pull/98#issuecomment-16514328
Landed in master in: https://github.com/mozilla/fjord/commit/a0b752290b149d6e6505583f024905c7d819afdc
Pushed to production just now. I verified that /happy and /sad redirect to the right place. I'll keep an eye on graphite and see if the 404 frequency goes down and will reopen if there are still issues.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 14•13 years ago
|
||
Making this a P1 and a 1 pointer.
Priority: -- → P1
Whiteboard: u=user c=feedback p= s=input.2013q2 → u=user c=feedback p=1 s=input.2013q2
| Assignee | ||
Updated•13 years ago
|
Summary: Happy/Sad button in FxBeta 21.0 goes to "Page Not Found" page → Happy/Sad button in toolbar for Firefox desktop beta 21.0 goes to "Page Not Found" page
| Assignee | ||
Comment 15•13 years ago
|
||
Aakash: Do the buttons go to the right place now?
| Assignee | ||
Comment 17•13 years ago
|
||
Awesome! Thank you for writing this up and verifying the fix!
| Reporter | ||
Comment 18•13 years ago
|
||
Thanks for getting the fix in so quickly :)
You need to log in
before you can comment on or make changes to this bug.
Description
•