862652 - cannot build mapihook using VS2012

Status: RESOLVED DUPLICATE of bug 860966

(MailNews Core :: Simple MAPI, defect)

Description

[Makoto Kato [:m_kato]]

build failure with VS2012.

142:00.09 c:/Development/hg.mozilla.org/comm-central/mailnews/mapi/mapihook/src/msgMapiImp.cpp(339) : error C2440: 'return' : cannot convert from 'tag_nsresult'
 to 'LONG'
142:00.10
142:00.10         This conversion requires an explicit cast (static_cast, C-style cast or function-style cast)
142:00.10
142:00.10 c:/Development/hg.mozilla.org/comm-central/mailnews/mapi/mapihook/src/msgMapiImp.cpp(385) : error C2440: 'return' : cannot convert from 'tag_nsresult' to 'HRESULT'
142:00.10
142:00.10         This conversion requires an explicit cast (static_cast, C-style cast or function-style cast)

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[rsx11m]

See bug 860966 attachment 736914 [details] [diff] [review] with an identical solution. Looks like requesting review for the patch over there has been forgotten...

Comment 3

[rsx11m]

Apparently on purpose:

(Quoting Frank Wein [:mcsmurf] from bug 860966 comment #3)
> This patch fixes the build, but still need to check if everything works as
> expected. I'm not sure what the meaning of the "// get the singelton obj"
> comment is in that context (when returning because of an error).

Comment 4

[Makoto Kato [:m_kato]]

(In reply to rsx11m from comment #2)
> See bug 860966 attachment 736914 [details] [diff] [review] with an identical
> solution. Looks like requesting review for the patch over there has been
> forgotten...

Thanks, rsx11m, I dup of that bug.

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 738295 [details] [diff] [review]
fix

cancel this for duplicated.

Comment 6

[Frank Wein [:mcsmurf]]

(In reply to rsx11m from comment #3)
> Apparently on purpose:
> 
> (Quoting Frank Wein [:mcsmurf] from bug 860966 comment #3)
> > This patch fixes the build, but still need to check if everything works as
> > expected. I'm not sure what the meaning of the "// get the singelton obj"
> > comment is in that context (when returning because of an error).

Yeah, I'm still not sure what that comment means :) but I checked a few other details on the MAPI API and the fix seems to be correct.