Note: There are a few cases of duplicates in user autocompletion which are being worked on.

geolocation settings tests fail with undefined mozSettings after bug 859601

RESOLVED FIXED in mozilla23

Status

()

Core
Geolocation
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

Trunk
mozilla23
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

After bug 859601, there is now a timing component to accessing mozSettings.  This causes the following test cases to fail when run individually or early in the mochitest run:

  dom/tests/mochitest/geolocation/test_mozsettings.html
  dom/tests/mochitest/geolocation/test_mozsettingsWatch.html

The current mochitest division on try does not trigger this, but it was exposed while working on bug 847279.

The solution recommend by reuben is to use addLoadEvent() to delay until mozSettings is available.
Created attachment 738320 [details] [diff] [review]
Handle mozSettings async creation using addLoadEvent().

Try showing the problem:

  https://tbpl.mozilla.org/?tree=Try&rev=979663f54c28

Try showing fix (ignore the android tests):

  https://tbpl.mozilla.org/?tree=Try&rev=e0b860105578
Assignee: nobody → ben
Attachment #738320 - Flags: review?(doug.turner)
(Assignee)

Updated

4 years ago
Attachment #738320 - Flags: feedback?(reuben.bmo)
Attachment #738320 - Flags: feedback?(reuben.bmo) → feedback+

Updated

4 years ago
Attachment #738320 - Flags: review?(doug.turner) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/78ccd7f5313f
Flags: in-testsuite+
Keywords: checkin-needed
Blocks: 847279
https://hg.mozilla.org/mozilla-central/rev/78ccd7f5313f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.