Last Comment Bug 862666 - geolocation settings tests fail with undefined mozSettings after bug 859601
: geolocation settings tests fail with undefined mozSettings after bug 859601
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Geolocation (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla23
Assigned To: Ben Kelly [:bkelly]
:
Mentors:
Depends on:
Blocks: 847279
  Show dependency treegraph
 
Reported: 2013-04-16 21:57 PDT by Ben Kelly [:bkelly]
Modified: 2013-04-17 13:07 PDT (History)
3 users (show)
ryanvm: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Handle mozSettings async creation using addLoadEvent(). (3.63 KB, patch)
2013-04-16 22:03 PDT, Ben Kelly [:bkelly]
josh: review+
reuben.bmo: feedback+
Details | Diff | Splinter Review

Description Ben Kelly [:bkelly] 2013-04-16 21:57:50 PDT
After bug 859601, there is now a timing component to accessing mozSettings.  This causes the following test cases to fail when run individually or early in the mochitest run:

  dom/tests/mochitest/geolocation/test_mozsettings.html
  dom/tests/mochitest/geolocation/test_mozsettingsWatch.html

The current mochitest division on try does not trigger this, but it was exposed while working on bug 847279.

The solution recommend by reuben is to use addLoadEvent() to delay until mozSettings is available.
Comment 1 Ben Kelly [:bkelly] 2013-04-16 22:03:55 PDT
Created attachment 738320 [details] [diff] [review]
Handle mozSettings async creation using addLoadEvent().

Try showing the problem:

  https://tbpl.mozilla.org/?tree=Try&rev=979663f54c28

Try showing fix (ignore the android tests):

  https://tbpl.mozilla.org/?tree=Try&rev=e0b860105578
Comment 2 Ryan VanderMeulen [:RyanVM] 2013-04-17 07:12:10 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/78ccd7f5313f
Comment 3 Ryan VanderMeulen [:RyanVM] 2013-04-17 13:07:21 PDT
https://hg.mozilla.org/mozilla-central/rev/78ccd7f5313f

Note You need to log in before you can comment on or make changes to this bug.