If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Xlib: form checkboxes are not drawn

VERIFIED FIXED

Status

()

Core
Layout: Form Controls
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: pocemit, Assigned: pocemit)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

17 years ago
When a form entry "checkbox" is present, such as in bugzilla bug screen, "remove
selected CCs", the checkmark is not drawn.

RenderingContext::FillPolygon was not implemented correctly.

Patch follows.
(Assignee)

Comment 1

17 years ago
Created attachment 38788 [details] [diff] [review]
Fix to nsRenderingContextXlib::FillPolygon
r=bryner
(Assignee)

Comment 3

17 years ago
Little background on why these changes were done:

change from Convex to Complex was done because there is only one FillPolygon
implementation, and the points array given to it can be either complex shape
(case of the checkmark on a checkbox widget), or simple shape like a rectangle
or something. Anyway, this is what fixes this bug.
the rest of the changes were just to make the code a little bit more readable.

Comment 4

17 years ago
++i is a better statement than i++, but for primitives this is more a style
issue than a performance one (beware postfix ++ and -- on real iterators,
though); and I know that was already in the code ... so I won't make you fix it.

sr=scc
(Assignee)

Comment 5

17 years ago
Created attachment 38813 [details] [diff] [review]
new patch per scc comments s/i++/++i
a=dbaron for trunk checkin (on behalf of drivers)

Comment 7

17 years ago
fix checked in
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 8

17 years ago
verifying on build 2001-06-21-04-trunk
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.