86267 - Xlib: form checkboxes are not drawn

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[pocemit]

When a form entry "checkbox" is present, such as in bugzilla bug screen, "remove
selected CCs", the checkmark is not drawn.

RenderingContext::FillPolygon was not implemented correctly.

Patch follows.

Comment 1

[pocemit]

Attachment: Fix to nsRenderingContextXlib::FillPolygon

Comment 2

[Brian Ryner (not reading)]

r=bryner

Comment 3

[pocemit]

Little background on why these changes were done:

change from Convex to Complex was done because there is only one FillPolygon
implementation, and the points array given to it can be either complex shape
(case of the checkmark on a checkbox widget), or simple shape like a rectangle
or something. Anyway, this is what fixes this bug.
the rest of the changes were just to make the code a little bit more readable.

Comment 4

[Scott Collins]

++i is a better statement than i++, but for primitives this is more a style
issue than a performance one (beware postfix ++ and -- on real iterators,
though); and I know that was already in the code ... so I won't make you fix it.

sr=scc

Comment 5

[pocemit]

Attachment: new patch per scc comments s/i++/++i

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

a=dbaron for trunk checkin (on behalf of drivers)

Comment 7

[timeless]

fix checked in

Comment 8

[Vladimir Ermakov]

verifying on build 2001-06-21-04-trunk