When a form entry "checkbox" is present, such as in bugzilla bug screen, "remove selected CCs", the checkmark is not drawn. RenderingContext::FillPolygon was not implemented correctly. Patch follows.
Little background on why these changes were done: change from Convex to Complex was done because there is only one FillPolygon implementation, and the points array given to it can be either complex shape (case of the checkmark on a checkbox widget), or simple shape like a rectangle or something. Anyway, this is what fixes this bug. the rest of the changes were just to make the code a little bit more readable.
++i is a better statement than i++, but for primitives this is more a style issue than a performance one (beware postfix ++ and -- on real iterators, though); and I know that was already in the code ... so I won't make you fix it. sr=scc
a=dbaron for trunk checkin (on behalf of drivers)
fix checked in
verifying on build 2001-06-21-04-trunk